You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/25 12:48:31 UTC

[GitHub] [doris] github-actions[bot] commented on pull request #13647: [enhancement](chore) build fe-common when build java-udf

github-actions[bot] commented on PR #13647:
URL: https://github.com/apache/doris/pull/13647#issuecomment-1290501846

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3319291572") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In build.sh line 459:
       "${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} ${MVN_PARAMS}
                                                             ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
       "${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} "${MVN_PARAMS}"
   
   For more information:
     https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- build.sh.orig
   +++ build.sh
   @@ -454,7 +454,7 @@
        fi
        MVN_PARAMS="-DskipTests"
        if [[ "$(uname -s)" = 'Darwin' ]]; then
   -      MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
   +        MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
        fi
        "${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} ${MVN_PARAMS}
        cd "${DORIS_HOME}"
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org