You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/16 11:42:25 UTC
[GitHub] [beam] piotr-szuberski opened a new pull request #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
piotr-szuberski opened a new pull request #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137
….matchSingleFileSpec
The code before masked the actual failure exception.
The MatchResult usecase assumes that if there was an error then calling for metadata throws an exception with the information of the actual error. I changed the code to propagate the exception when accessing the metadata throws.
R: @mwalenia @kamilwu
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599508448
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-600011416
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599560521
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599508375
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] piotr-szuberski edited a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
piotr-szuberski edited a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-601161707
@mwalenia the tests passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599912960
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599583839
run java precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599508653
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-601618228
LGTM, but to be on the safe side: @kennknowles can you take a look? Won't this have any adverse or unforseen side effects?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-600096815
run java precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-601024107
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] piotr-szuberski commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-601161707
@mwalenia at least tests passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599512502
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599508653
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599584214
run java precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599492032
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599512502
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599508375
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] piotr-szuberski edited a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
piotr-szuberski edited a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-601161707
@mwalenia at least the tests passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-600467924
run java precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
Posted by GitBox <gi...@apache.org>.
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…
URL: https://github.com/apache/beam/pull/11137#issuecomment-599508448
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services