You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/01/14 11:33:28 UTC

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #631: [SCB-1696] Optimize state machine compensation retry strategy using reverseRetries and retryDelayInMilliseconds for FSM

WillemJiang commented on a change in pull request #631: [SCB-1696] Optimize state machine compensation retry strategy using reverseRetries and retryDelayInMilliseconds for FSM
URL: https://github.com/apache/servicecomb-pack/pull/631#discussion_r366288601
 
 

 ##########
 File path: pack-contracts/pack-contract-grpc/src/main/proto/GrpcTxEvent.proto
 ##########
 @@ -42,9 +42,13 @@ message GrpcTxEvent {
   bytes payloads = 7;
   string serviceName = 8;
   string instanceId = 9;
-  int32 forwardTimeout = 10;
-  int32 forwardRetries = 11;
-  string retryMethod = 12;
+  int32 timeout = 10;
 
 Review comment:
   We need to mention the change of GrpcTxEvent.proto in the release note,  to notify other language client for updating.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services