You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Eduardo Ponce (Jira)" <ji...@apache.org> on 2021/07/13 19:49:00 UTC

[jira] [Commented] (ARROW-13327) [Python] Improve consistency of explicit C++ types in PyArrow .pyx files

    [ https://issues.apache.org/jira/browse/ARROW-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380135#comment-17380135 ] 

Eduardo Ponce commented on ARROW-13327:
---------------------------------------

Actually, the description files (e.g. libarrow.pxd) contains the explicit types of the function options parameters, so I do not think it is necessary to add explicit types to the implementation files.

> [Python] Improve consistency of explicit C++ types in PyArrow .pyx files
> ------------------------------------------------------------------------
>
>                 Key: ARROW-13327
>                 URL: https://issues.apache.org/jira/browse/ARROW-13327
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Eduardo Ponce
>            Priority: Minor
>             Fix For: 6.0.0
>
>
> Cython files (.pyx) in PyArrow make inconsistent use of explicit C++ typing. Some methods/functions use explicit types for their parameters and others do not. We should establish a guideline of when an explicit C++ type is desired, and conform to this guideline. This issue should help establish these guideline rules and apply them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)