[GitHub] [iceberg] rdblue commented on a diff in pull request #5303: Add a BoundBooleanExpressionVisitor for visiting bound expressions

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5303:
URL: https://github.com/apache/iceberg/pull/5303#discussion_r925116064


##########
python/pyiceberg/expressions/base.py:
##########
@@ -327,30 +328,26 @@ def bind(self, schema: Schema, case_sensitive: bool) -> BoundIn[T]:
         return BoundIn(bound_ref, tuple(lit.to(bound_ref.field.field_type) for lit in self.literals))  # type: ignore
 
 
-class BooleanExpressionVisitor(Generic[T], ABC):

Review Comment:
   I don't think this is a good idea. Don't we want to ensure that all of the cases are handled? What is the return value of visit methods that are not implemented? `None`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org