[jira] [Updated] (SPARK-8815) illegal java package names in jar

["Sean Owen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated SPARK-8815:
-----------------------------
       Priority: Minor  (was: Major)
    Component/s: Spark Core

PS I do see that package names are just identifiers in java and they can't have hyphen, check. I'm wondering if there is any more specific reason to expect that the JVM does or doesn't reject it.

I suspect it would not hurt to just change the shaded package since nobody should be depending on that. But it might also be valid actually at the point where this identifier is consumed. I still suspect it's a happens-to-work situation rather than must-work.

> illegal java package names in jar
> ---------------------------------
>
>                 Key: SPARK-8815
>                 URL: https://issues.apache.org/jira/browse/SPARK-8815
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>            Reporter: Sam Halliday
>            Priority: Minor
>
> In ENSIME we were unable to index the spark jars and we investigated further... you have classes that look like this:
> org.spark-project.guava.annotations.VisibleForTesting
> Hyphens are not legal package names according to the java language spec, so I'm amazed that this can actually be read at runtime... certainly no compiler I know would allow it.
> What I suspect is happening is that you're using a build plugin that internalises some of your dependencies and it is using your groupId but not validating it... and then blindly using that name in the ASM manipulation.
> You might want to report this upstream with your build plugin.
> For your next release, I recommend using an explicit name that is not your groupId. i.e. convert hyphens to underscores as Gosling recommends.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org