You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/09/09 17:26:56 UTC
[GitHub] [mynewt-core] utzig commented on a change in pull request #1980:
stm32 hal_timer small fixes
utzig commented on a change in pull request #1980: stm32 hal_timer small fixes
URL: https://github.com/apache/mynewt-core/pull/1980#discussion_r322362267
##########
File path: hw/mcu/stm/stm32_common/src/hal_timer.c
##########
@@ -94,9 +94,8 @@ stm32_tmr_cbs(struct stm32_hal_tmr *tmr)
}
ht = TAILQ_FIRST(&tmr->sht_timers);
if (ht) {
- tmr->sht_regs->CCR1 = ht->expiry;
+ tmr->sht_regs->CCR1 = ht->expiry & 0xFFFFU;
Review comment:
I wonder if this is required. The `CCR1` register is still 32-bits, which for some models (F1 only?) will just write expiry on the 16 lower bits and ignore high word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services