[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #231: [FLINK-31374] ProxyStreamPartitioner should implement ConfigurableStreamPartitioner

["zhipeng93 (via GitHub)" <gi...@apache.org>]

zhipeng93 commented on code in PR #231:
URL: https://github.com/apache/flink-ml/pull/231#discussion_r1162807385


##########
flink-ml-iteration/src/main/java/org/apache/flink/iteration/proxy/ProxyStreamPartitioner.java:
##########
@@ -98,4 +100,12 @@ public int selectChannel(SerializationDelegate<StreamRecord<IterationRecord<T>>>
     public String toString() {
         return wrappedStreamPartitioner.toString();
     }
+
+    @Override
+    public void configure(int maxParallelism) {
+        if (wrappedStreamPartitioner instanceof ConfigurableStreamPartitioner) {
+            ((ConfigurableStreamPartitioner) this.wrappedStreamPartitioner)

Review Comment:
   nit: Let's move `this.` for consistency.



##########
flink-ml-iteration/src/main/java/org/apache/flink/iteration/proxy/ProxyStreamPartitioner.java:
##########
@@ -98,4 +100,12 @@ public int selectChannel(SerializationDelegate<StreamRecord<IterationRecord<T>>>
     public String toString() {
         return wrappedStreamPartitioner.toString();
     }
+
+    @Override
+    public void configure(int maxParallelism) {
+        if (wrappedStreamPartitioner instanceof ConfigurableStreamPartitioner) {
+            ((ConfigurableStreamPartitioner) this.wrappedStreamPartitioner)

Review Comment:
   nit: Let's remove `this.` for consistency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org