You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2021/02/04 14:06:45 UTC
[GitHub] [incubator-sedona] michaelmerg opened a new pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
michaelmerg opened a new pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507
## Is this PR related to a proposed Issue?
https://issues.apache.org/jira/browse/SEDONA-15
## What changes were proposed in this PR?
Add the new geometry processing functions:
- ST_MinimumBoundingRadius
- ST_MinimumBoundingCircle
## How was this patch tested?
See unit tests
## Did this PR include necessary documentation updates?
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on a change in pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#discussion_r570745502
##########
File path: docs/api/sql/GeoSparkSQL-Function.md
##########
@@ -583,4 +583,32 @@ FROM df
Input: `POINT (1 2)`
-Output: `POINT (2 1)`
\ No newline at end of file
+Output: `POINT (2 1)`
+
+
+## ST_MinimumBoundingRadius
+
+Introduction: Returns a struct containing the center point and radius of the smallest circle that contains a geometry.
+
+Format: `ST_MinimumBoundingRadius(geom: geometry)`
+
+Since: `v1.?.?`
Review comment:
Please put Since: `1.0.1` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#issuecomment-774428360
@michaelmerg To make it robust, since ST_ functions internally call JTS functions, so probably you can call JTS function to validate the result in the test, instead of hard-coding the test result? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] michaelmerg commented on a change in pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
michaelmerg commented on a change in pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#discussion_r570766316
##########
File path: docs/api/sql/GeoSparkSQL-Function.md
##########
@@ -583,4 +583,32 @@ FROM df
Input: `POINT (1 2)`
-Output: `POINT (2 1)`
\ No newline at end of file
+Output: `POINT (2 1)`
+
+
+## ST_MinimumBoundingRadius
+
+Introduction: Returns a struct containing the center point and radius of the smallest circle that contains a geometry.
+
+Format: `ST_MinimumBoundingRadius(geom: geometry)`
+
+Since: `v1.?.?`
Review comment:
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#issuecomment-775759958
@michaelmerg Thank you very much for the contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] michaelmerg commented on pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
michaelmerg commented on pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#issuecomment-775753249
@jiayuasu Yes, that's a good idea. I updated the test case.
Is there anything else that I need to do before we can merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] michaelmerg commented on pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
michaelmerg commented on pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#issuecomment-773850006
Sorry, forgot to commit the test cases.
I'm not 100% happy with the `ST_MinimumBoundingCircle` test case because of the odd numbers when comparing the strings. Do you have any suggestions to improve of make it more robust?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu merged pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] michaelmerg commented on pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
michaelmerg commented on pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#issuecomment-773850006
Sorry, forgot to commit the test cases.
I'm not 100% happy with the `ST_MinimumBoundingCircle` test case because of the odd numbers when comparing the strings. Do you have any suggestions to improve of make it more robust?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on a change in pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#discussion_r570745502
##########
File path: docs/api/sql/GeoSparkSQL-Function.md
##########
@@ -583,4 +583,32 @@ FROM df
Input: `POINT (1 2)`
-Output: `POINT (2 1)`
\ No newline at end of file
+Output: `POINT (2 1)`
+
+
+## ST_MinimumBoundingRadius
+
+Introduction: Returns a struct containing the center point and radius of the smallest circle that contains a geometry.
+
+Format: `ST_MinimumBoundingRadius(geom: geometry)`
+
+Since: `v1.?.?`
Review comment:
Please put Since: `1.0.1` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] michaelmerg commented on a change in pull request #507: [SEDONA-15] Add ST_MinimumBoundingRadius and ST_MinimumBoundingCircle functions
Posted by GitBox <gi...@apache.org>.
michaelmerg commented on a change in pull request #507:
URL: https://github.com/apache/incubator-sedona/pull/507#discussion_r570766316
##########
File path: docs/api/sql/GeoSparkSQL-Function.md
##########
@@ -583,4 +583,32 @@ FROM df
Input: `POINT (1 2)`
-Output: `POINT (2 1)`
\ No newline at end of file
+Output: `POINT (2 1)`
+
+
+## ST_MinimumBoundingRadius
+
+Introduction: Returns a struct containing the center point and radius of the smallest circle that contains a geometry.
+
+Format: `ST_MinimumBoundingRadius(geom: geometry)`
+
+Since: `v1.?.?`
Review comment:
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org