You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/20 22:59:29 UTC

[GitHub] [kafka] mjsax opened a new pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

mjsax opened a new pull request #9634:
URL: https://github.com/apache/kafka/pull/9634


   Call for review @wcarlson5 @guozhangwang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-731499093


   Merged to `trunk` and cherry-picked to `2.6`. Will cherry pick to `2.7` after release is done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-731450981


   LGTM! Please feel free to merge if local unit test passes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-731513666


   Looks this broke the build. Did we check that the PR passed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax merged pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9634:
URL: https://github.com/apache/kafka/pull/9634


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-731626196


   Jenkins build was green... Not sure how this happened.
   
   It seems, I did start the PR from a stale local `trunk` branch. But Jenkins build should have caught the issue. Not sure why?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-733178631


   Cherry-picked to `2.7` branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org