You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/11 12:33:06 UTC
[GitHub] [incubator-pekko-connectors] pjfanning opened a new pull request, #218: scalafmt 3.7.11
pjfanning opened a new pull request, #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218
matches other repos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #218: scalafmt 3.7.11
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218#issuecomment-1674812050
Can you separate the change to `jms/src/test/scala/docs/scaladsl/JmsConnectorsSpec.scala` in its own commit so it can be added distinctly into `.git-blame-ignore-revs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #218: scalafmt 3.7.11
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218#issuecomment-1675063071
@pjfanning Shall I just recreate this PR with the proper commit structure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #218: scalafmt 3.7.11
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218#issuecomment-1675065208
@mdedetrich if you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #218: scalafmt 3.7.11
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218#issuecomment-1674818561
> the scalafmt change caused the change
Yes
> it will fail the build if I separate it
No it wont as long as its in a single PR, I have done this all the time (i.e. see https://github.com/apache/incubator-pekko/pull/509/commits).
I also have a specific way of creating the format commit so its consistent with past formatting commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning closed pull request #218: scalafmt 3.7.11
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #218: scalafmt 3.7.11
URL: https://github.com/apache/incubator-pekko-connectors/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #218: scalafmt 3.7.11
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218#issuecomment-1674812303
Alternately I can do this ontop of your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #218: scalafmt 3.7.11
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218#issuecomment-1674815186
the scalafmt change caused the change? it will fail the build if I separate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #218: scalafmt 3.7.11
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #218:
URL: https://github.com/apache/incubator-pekko-connectors/pull/218#issuecomment-1675112911
Done https://github.com/apache/incubator-pekko-connectors/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org