You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "pvcnt (via GitHub)" <gi...@apache.org> on 2023/11/09 10:21:03 UTC
[PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]
pvcnt opened a new pull request, #2071:
URL: https://github.com/apache/solr/pull/2071
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]
Posted by "pvcnt (via GitHub)" <gi...@apache.org>.
pvcnt commented on PR #2071:
URL: https://github.com/apache/solr/pull/2071#issuecomment-1814016666
I added a line in CHANGES.txt and a precision in documentation about the class attribute in solr.xml. Btw, there are tests in `TestXLSXResponseWriter` failing in CI, but I cannot reproduce locally (and it does not really seem related to my change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]
Posted by "pvcnt (via GitHub)" <gi...@apache.org>.
pvcnt commented on PR #2071:
URL: https://github.com/apache/solr/pull/2071#issuecomment-1810514488
Sure, I was looking for feedback about the approach first! Since this looks acceptable, I added some tests and documentation for the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]
Posted by "ycallea (via GitHub)" <gi...@apache.org>.
ycallea commented on PR #2071:
URL: https://github.com/apache/solr/pull/2071#issuecomment-1812759183
Thanks @pvcnt for proposing this enhancement, `solr.xml` definitely feels like a great place for configuring placement plugins 🙂
I am looking forward to this feature especially for configuring the Affinity placement plugin without having to rely on the `/cluster/plugin` API !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]
Posted by "pvcnt (via GitHub)" <gi...@apache.org>.
pvcnt commented on code in PR #2071:
URL: https://github.com/apache/solr/pull/2071#discussion_r1392873965
##########
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java:
##########
@@ -150,7 +150,7 @@ public AffinityPlacementConfig getConfig() {
* See {@link AffinityPlacementFactory} for instructions on how to configure a cluster to use this
* plugin and details on what the plugin does.
*/
- static class AffinityPlacementPlugin extends OrderedNodePlacementPlugin {
+ public static class AffinityPlacementPlugin extends OrderedNodePlacementPlugin {
Review Comment:
That is unfortunate. Couldn't figure out how to test it otherwise. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #2071:
URL: https://github.com/apache/solr/pull/2071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on PR #2071:
URL: https://github.com/apache/solr/pull/2071#issuecomment-1819085178
> ... Btw, there are tests in `TestXLSXResponseWriter` failing in CI, but I cannot reproduce locally (and it does not really seem related to my change).
Filed https://issues.apache.org/jira/browse/SOLR-17081 for visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2071:
URL: https://github.com/apache/solr/pull/2071#issuecomment-1818326814
The XLSX issue is only on Crave pertaining to the JDK used there being somewhat incomplete. I reported it and it should be fixed soon if not already.
So I merged this but I should have checked more carefully; there are test failures. For example PlacementPluginIntegrationTest has 3 new tests and they create a CoreContainer but don't shut them down. I pushed a quick fix for that. But there are also test failures in OverseerCollectionConfigSetProcessorTest. I ignored that test temporarily; can you please look into this soon with fix PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]
Posted by "pvcnt (via GitHub)" <gi...@apache.org>.
pvcnt commented on PR #2071:
URL: https://github.com/apache/solr/pull/2071#issuecomment-1818435207
Ooops, sorry about that. Is there a view of all tests failures in a CI run? Or is there a way to configure that? I know that in Jenkins we can have a specific view of all failing tests instead of scrolling into logs looking for failing tests buried somewhere.
Anyway, thank you for fixing one of those, and here is the fix for the other one: #2085 2085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-15782: Declare PlacementPlugin in solr.xml [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2071:
URL: https://github.com/apache/solr/pull/2071#issuecomment-1810385153
Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org