You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by su...@apache.org on 2021/05/17 02:02:41 UTC

[apisix-dashboard] branch master updated: chore: refactored test create-route-with-proxy-mirror-form.spec.js (#1866)

This is an automated email from the ASF dual-hosted git repository.

sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
     new c98cb8e  chore: refactored test create-route-with-proxy-mirror-form.spec.js (#1866)
c98cb8e is described below

commit c98cb8e865513fe3fd9f30e54900e8fa8d8a836d
Author: Ayush das <ay...@gmail.com>
AuthorDate: Mon May 17 07:32:34 2021 +0530

    chore: refactored test create-route-with-proxy-mirror-form.spec.js (#1866)
---
 .../create-route-with-proxy-mirror-form.spec.js    | 93 +++++++++++++---------
 1 file changed, 56 insertions(+), 37 deletions(-)

diff --git a/web/cypress/integration/route/create-route-with-proxy-mirror-form.spec.js b/web/cypress/integration/route/create-route-with-proxy-mirror-form.spec.js
index 87ac24d..790e1d6 100644
--- a/web/cypress/integration/route/create-route-with-proxy-mirror-form.spec.js
+++ b/web/cypress/integration/route/create-route-with-proxy-mirror-form.spec.js
@@ -18,69 +18,90 @@
 
 context('Create and delete route with proxy-mirror form', () => {
   const selector = {
-    host: "#host",
-    alert: ".ant-form-item-explain"
-  }
+    empty: '.ant-empty-normal',
+    name: '#name',
+    description: '#desc',
+    disabledSwitcher: '#disable',
+    drawer: '.ant-drawer-content',
+    pluginCardBordered: '.ant-card-bordered',
+    checkedSwitcher: '.ant-switch-checked',
+    nodes_0_host: '#nodes_0_host',
+    nodes_0_port: '#nodes_0_port',
+    nodes_0_weight: '#nodes_0_weight',
+    deleteAlert: '.ant-modal-body',
+    notificationCloseIcon: '.ant-notification-close-icon',
+    notification: '.ant-notification-notice-message',
+    host: '#host',
+    alert: '.ant-form-item-explain',
+  };
+
+  const data = {
+    deleteRouteSuccess: 'Delete Route Successfully',
+    submitSuccess: 'Submit Successfully',
+    port: '80',
+    weight: 1,
+  };
 
   beforeEach(() => {
     cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
   });
 
   it('should create route with proxy-mirror form', function () {
     cy.visit('/');
     cy.contains('Route').click();
-    cy.get(this.domSelector.empty).should('be.visible');
+    cy.get(selector.empty).should('be.visible');
     cy.contains('Create').click();
     cy.contains('Next').click().click();
-    cy.get(this.domSelector.name).type('routeName');
-    cy.get(this.domSelector.description).type('desc');
+    cy.get(selector.name).type('routeName');
+    cy.get(selector.description).type('desc');
     cy.contains('Next').click();
 
-    cy.get(this.domSelector.nodes_0_host).type('127.0.0.1');
-    cy.get(this.domSelector.nodes_0_port).clear().type(this.data.port);
-    cy.get(this.domSelector.nodes_0_weight).clear().type(this.data.weight);
+    cy.get(selector.nodes_0_host).type('127.0.0.1');
+    cy.get(selector.nodes_0_port).clear().type(data.port);
+    cy.get(selector.nodes_0_weight).clear().type(data.weight);
     cy.contains('Next').click();
 
     // config proxy-mirror plugin
-    cy.contains('proxy-mirror').parents(this.domSelector.pluginCardBordered).within(() => {
-      cy.get('button').click({
-        force: true
+    cy.contains('proxy-mirror')
+      .parents(selector.pluginCardBordered)
+      .within(() => {
+        cy.get('button').click({
+          force: true,
+        });
       });
-    });
 
-    cy.get(this.domSelector.drawer).should('be.visible').within(() => {
-      cy.get(this.domSelector.disabledSwitcher).click();
-      cy.get(this.domSelector.checkedSwitcher).should('exist');
-    });
+    cy.get(selector.drawer)
+      .should('be.visible')
+      .within(() => {
+        cy.get(selector.disabledSwitcher).click();
+        cy.get(selector.checkedSwitcher).should('exist');
+      });
 
     // config proxy-mirror form with wrong host
     cy.get(selector.host).type('127.0.0.1:1999');
     cy.get(selector.alert).contains('address needs to contain schema: http or https, not URI part');
-    cy.get(this.domSelector.drawer).within(() => {
+    cy.get(selector.drawer).within(() => {
       cy.contains('Submit').click({
         force: true,
       });
     });
-    cy.get(this.domSelector.notification).should('contain', 'Invalid plugin data');
-    cy.get(this.domSelector.notificationCloseIcon).click();
+    cy.get(selector.notification).should('contain', 'Invalid plugin data');
+    cy.get(selector.notificationCloseIcon).click();
 
     // config proxy-mirror form with correct host
     cy.get(selector.host).clear().type('http://127.0.0.1:1999');
     cy.get(selector.alert).should('not.exist');
-    cy.get(this.domSelector.disabledSwitcher).click();
-    cy.get(this.domSelector.drawer).within(() => {
+    cy.get(selector.disabledSwitcher).click();
+    cy.get(selector.drawer).within(() => {
       cy.contains('Submit').click({
         force: true,
       });
     });
-    cy.get(this.domSelector.drawer).should('not.exist');
+    cy.get(selector.drawer).should('not.exist');
 
     cy.contains('button', 'Next').click();
     cy.contains('button', 'Submit').click();
-    cy.contains(this.data.submitSuccess);
+    cy.contains(data.submitSuccess);
 
     // back to route list page
     cy.contains('Goto List').click();
@@ -89,19 +110,17 @@ context('Create and delete route with proxy-mirror form', () => {
 
   it('should delete the route', function () {
     cy.visit('/routes/list');
-    const {
-      domSelector,
-      data
-    } = this;
 
-    cy.get(domSelector.name).clear().type('routeName');
+    cy.get(selector.name).clear().type('routeName');
     cy.contains('Search').click();
     cy.contains('routeName').siblings().contains('More').click();
     cy.contains('Delete').click();
-    cy.get(domSelector.deleteAlert).should('be.visible').within(() => {
-      cy.contains('OK').click();
-    });
-    cy.get(domSelector.notification).should('contain', data.deleteRouteSuccess);
-    cy.get(domSelector.notificationCloseIcon).click({ multiple: true });
+    cy.get(selector.deleteAlert)
+      .should('be.visible')
+      .within(() => {
+        cy.contains('OK').click();
+      });
+    cy.get(selector.notification).should('contain', data.deleteRouteSuccess);
+    cy.get(selector.notificationCloseIcon).click({ multiple: true });
   });
 });