You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "justfortaste (via GitHub)" <gi...@apache.org> on 2024/09/02 01:48:07 UTC
[PR] [feature](func) support timestmamp(datetime, zone), DATE(datetime,zone) [doris]
justfortaste opened a new pull request, #40231:
URL: https://github.com/apache/doris/pull/40231
SELECT TIMESTAMP("2008-12-25 15:30:00", "America/Los_Angeles") AS timestamp_str;
+---------------------+
| timestamp_str |
+---------------------+
| 2008-12-24 23:30:00 |
+---------------------+
1 row in set (0.01 sec)
select date(datetime '2020-01-01 23:00:00','Asia/Shanghai');
+----------------------------------------------------------------+
| date(CAST('2020-01-01 23:00:00' AS datetime), 'Asia/Shanghai') |
+----------------------------------------------------------------+
| 2020-01-02 |
+----------------------------------------------------------------+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2326471162
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2343910190
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2329217264
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323625273
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2329174405
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2324601592
<details>
<summary>TPC-DS: <b>Total hot run time: 191357 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c2b5ffe6e477a08dd81d8cffdbdbc917f8803a38, data reload: false
query1 1234 924 872 872
query2 6317 2046 2051 2046
query3 10599 3904 3863 3863
query4 59318 24794 23237 23237
query5 5353 495 491 491
query6 398 175 165 165
query7 5775 287 303 287
query8 277 196 199 196
query9 9108 2477 2458 2458
query10 472 267 256 256
query11 16839 14942 15079 14942
query12 162 102 102 102
query13 1601 405 378 378
query14 11238 6921 6574 6574
query15 229 184 180 180
query16 7615 499 458 458
query17 1112 556 575 556
query18 2072 312 292 292
query19 289 149 142 142
query20 114 110 111 110
query21 204 113 103 103
query22 4677 4500 4564 4500
query23 34385 33279 33307 33279
query24 5962 2879 2849 2849
query25 542 390 396 390
query26 673 152 153 152
query27 1766 288 285 285
query28 3900 2066 2043 2043
query29 709 425 423 423
query30 229 152 157 152
query31 922 750 791 750
query32 87 98 51 51
query33 460 279 266 266
query34 854 470 472 470
query35 847 707 701 701
query36 1048 926 939 926
query37 149 90 85 85
query38 4055 3825 3924 3825
query39 1445 1393 1371 1371
query40 200 111 112 111
query41 44 44 42 42
query42 114 93 93 93
query43 512 465 484 465
query44 1089 734 746 734
query45 193 174 182 174
query46 1075 731 721 721
query47 1909 1794 1827 1794
query48 354 287 298 287
query49 757 441 427 427
query50 819 423 416 416
query51 7055 6905 6736 6736
query52 97 85 85 85
query53 246 174 175 174
query54 561 456 456 456
query55 77 76 75 75
query56 270 238 245 238
query57 1190 1084 1077 1077
query58 229 219 222 219
query59 3166 2967 2896 2896
query60 289 264 276 264
query61 97 99 99 99
query62 764 632 662 632
query63 210 183 181 181
query64 2616 667 641 641
query65 3188 3155 3190 3155
query66 692 340 331 331
query67 15318 15412 15199 15199
query68 3008 568 567 567
query69 405 270 281 270
query70 1176 1151 1117 1117
query71 359 282 263 263
query72 6195 3960 4019 3960
query73 749 326 328 326
query74 9213 8853 8838 8838
query75 3348 2673 2675 2673
query76 1456 1000 914 914
query77 573 319 329 319
query78 9663 9265 9036 9036
query79 1042 526 521 521
query80 673 496 484 484
query81 464 238 231 231
query82 235 139 146 139
query83 170 148 149 148
query84 259 76 72 72
query85 683 326 272 272
query86 308 311 302 302
query87 4405 4312 4214 4214
query88 3385 2295 2288 2288
query89 399 288 275 275
query90 1980 190 183 183
query91 121 98 96 96
query92 62 46 48 46
query93 1063 534 530 530
query94 727 276 294 276
query95 340 249 245 245
query96 580 267 269 267
query97 3180 3077 3078 3077
query98 217 194 196 194
query99 1531 1266 1266 1266
Total cold run time: 304136 ms
Total hot run time: 191357 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #40231:
URL: https://github.com/apache/doris/pull/40231#discussion_r1743176699
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -1359,7 +1359,7 @@ specifiedPartition
constant
: NULL #nullLiteral
- | type=(DATE | DATEV1 | DATEV2 | TIMESTAMP) STRING_LITERAL #typeConstructor
+ | type=(DATE | DATEV1 | DATEV2 | DATETIME| DATETIMEV2 | TIMESTAMP) STRING_LITERAL #typeConstructor
Review Comment:
why change this? if u change this u should update org.apache.doris.nereids.parser.LogicalPlanBuilder#visitTypeConstructor
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Timestamp.java:
##########
@@ -41,9 +42,15 @@ public class Timestamp extends ScalarFunction
// This preference follows original planner. refer to ScalarType.getDefaultDateType()
public static final List<FunctionSignature> SIGNATURES = Config.enable_date_conversion ? ImmutableList.of(
FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT).args(DateTimeV2Type.SYSTEM_DEFAULT),
+ FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT).args(DateTimeV2Type.SYSTEM_DEFAULT,
+ VarcharType.SYSTEM_DEFAULT),
+ FunctionSignature.ret(DateTimeType.INSTANCE).args(DateTimeType.INSTANCE, VarcharType.SYSTEM_DEFAULT),
FunctionSignature.ret(DateTimeType.INSTANCE).args(DateTimeType.INSTANCE)
Review Comment:
please groups by arg count, e.g. put 1 arg signatures togather and 2 args signatures togather
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java:
##########
@@ -330,6 +330,43 @@ public static Expression date(DateTimeV2Literal dateTime) throws AnalysisExcepti
return new DateV2Literal(dateTime.getYear(), dateTime.getMonth(), dateTime.getDay());
}
+ /**
+ * date
+ */
+ @ExecFunction(name = "date", argTypes = {"DATETIME", "VARCHAR"}, returnType = "DATE")
+ public static Expression date(DateTimeLiteral datetime, StringLikeLiteral toTz) {
+ DateTimeFormatter zoneFormatter = new DateTimeFormatterBuilder()
+ .parseCaseInsensitive()
+ .appendZoneOrOffsetId()
+ .toFormatter()
+ .withResolverStyle(ResolverStyle.STRICT);
+ ZoneId toZone = ZoneId.from(zoneFormatter.parse(toTz.getStringValue()));
+
+ LocalDateTime localDateTime = datetime.toJavaDateType();
+ ZonedDateTime resultDateTime = localDateTime.atZone(DateUtils.getTimeZone()).withZoneSameInstant(toZone);
+ localDateTime = resultDateTime.toLocalDateTime();
+ return new DateV2Literal(localDateTime.getYear(), localDateTime.getMonthValue(), localDateTime.getDayOfMonth());
Review Comment:
should return DateLiteral
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Date.java:
##########
@@ -53,13 +56,25 @@ public Date(Expression arg) {
super("date", arg);
}
+ /**
+ * constructor with 1 argument.
Review Comment:
```suggestion
* constructor with 2 argument.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2343977547
TeamCity be ut coverage result:
Function Coverage: 36.88% (9457/25646)
Line Coverage: 28.22% (77747/275493)
Region Coverage: 27.62% (40122/145274)
Branch Coverage: 24.23% (20382/84116)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6fa461a244a42b5448f495769f8c19fb5fc73e9b_6fa461a244a42b5448f495769f8c19fb5fc73e9b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323655356
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323692074
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #40231:
URL: https://github.com/apache/doris/pull/40231#discussion_r1743229014
##########
be/src/vec/functions/function_convert_tz.h:
##########
@@ -207,4 +209,323 @@ class FunctionConvertTZ : public IFunction {
}
};
+template <typename ArgDateType>
+class FunctionDateTZ : public IFunction {
+ using DateValueType = date_cast::TypeToValueTypeV<ArgDateType>;
+ using ArgColumnType = date_cast::TypeToColumnV<ArgDateType>;
+ using NativeType = date_cast::ValueTypeOfColumnV<ArgColumnType>;
+ constexpr static bool is_v1 = date_cast::IsV1<ArgDateType>();
+ using TempDateType = std::conditional_t<is_v1, DataTypeDateTime, ArgDateType>;
+ using TempDateValueType = date_cast::TypeToValueTypeV<TempDateType>;
+ using ReturnDateType = std::conditional_t<is_v1, DataTypeDate, DataTypeDateV2>; //todo
+ using ReturnDateValueType = date_cast::TypeToValueTypeV<ReturnDateType>;
+ using ReturnColumnType = date_cast::TypeToColumnV<ReturnDateType>;
+ using ReturnNativeType = date_cast::ValueTypeOfColumnV<ReturnColumnType>;
+
+public:
+ static constexpr auto name = "date";
+
+ static FunctionPtr create() { return std::make_shared<FunctionDateTZ>(); }
+
+ String get_name() const override { return name; }
+
+ size_t get_number_of_arguments() const override { return 2; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ if constexpr (is_v1) {
+ return make_nullable(std::make_shared<DataTypeDate>());
+ } else {
+ return make_nullable(std::make_shared<DataTypeDateV2>());
+ }
+ }
+
+ bool is_variadic() const override { return true; }
+
+ DataTypes get_variadic_argument_types_impl() const override {
+ return {std::make_shared<ArgDateType>(), std::make_shared<DataTypeString>()};
+ }
+
+ bool use_default_implementation_for_nulls() const override { return false; }
+
+ Status close(FunctionContext* context, FunctionContext::FunctionStateScope scope) override {
+ return Status::OK();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override {
+ auto result_null_map_column = ColumnUInt8::create(input_rows_count, 0);
+
+ bool col_const[3];
+ ColumnPtr argument_columns[2];
+ for (int i = 0; i < 2; ++i) {
+ col_const[i] = is_column_const(*block.get_by_position(arguments[i]).column);
+ }
+ argument_columns[0] = col_const[0] ? static_cast<const ColumnConst&>(
+ *block.get_by_position(arguments[0]).column)
+ .convert_to_full_column()
+ : block.get_by_position(arguments[0]).column;
+
+ default_preprocess_parameter_columns(argument_columns, col_const, {1}, block, arguments);
+
+ for (int i = 0; i < 2; i++) {
+ check_set_nullable(argument_columns[i], result_null_map_column, col_const[i]);
Review Comment:
then you could remove this.
##########
be/src/vec/functions/function_convert_tz.h:
##########
@@ -207,4 +209,323 @@ class FunctionConvertTZ : public IFunction {
}
};
+template <typename ArgDateType>
+class FunctionDateTZ : public IFunction {
+ using DateValueType = date_cast::TypeToValueTypeV<ArgDateType>;
+ using ArgColumnType = date_cast::TypeToColumnV<ArgDateType>;
+ using NativeType = date_cast::ValueTypeOfColumnV<ArgColumnType>;
+ constexpr static bool is_v1 = date_cast::IsV1<ArgDateType>();
+ using TempDateType = std::conditional_t<is_v1, DataTypeDateTime, ArgDateType>;
+ using TempDateValueType = date_cast::TypeToValueTypeV<TempDateType>;
+ using ReturnDateType = std::conditional_t<is_v1, DataTypeDate, DataTypeDateV2>; //todo
+ using ReturnDateValueType = date_cast::TypeToValueTypeV<ReturnDateType>;
+ using ReturnColumnType = date_cast::TypeToColumnV<ReturnDateType>;
+ using ReturnNativeType = date_cast::ValueTypeOfColumnV<ReturnColumnType>;
+
+public:
+ static constexpr auto name = "date";
+
+ static FunctionPtr create() { return std::make_shared<FunctionDateTZ>(); }
+
+ String get_name() const override { return name; }
+
+ size_t get_number_of_arguments() const override { return 2; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ if constexpr (is_v1) {
+ return make_nullable(std::make_shared<DataTypeDate>());
+ } else {
+ return make_nullable(std::make_shared<DataTypeDateV2>());
+ }
+ }
+
+ bool is_variadic() const override { return true; }
+
+ DataTypes get_variadic_argument_types_impl() const override {
+ return {std::make_shared<ArgDateType>(), std::make_shared<DataTypeString>()};
+ }
+
+ bool use_default_implementation_for_nulls() const override { return false; }
Review Comment:
should be true(that is ,remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2326471076
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2329306310
TeamCity be ut coverage result:
Function Coverage: 36.82% (9396/25517)
Line Coverage: 28.26% (77458/274131)
Region Coverage: 27.65% (39970/144536)
Branch Coverage: 24.29% (20329/83688)
Coverage Report: http://coverage.selectdb-in.cc/coverage/66909449084c3f011b4fa536076d71f272f37c97_66909449084c3f011b4fa536076d71f272f37c97/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40231: [feature](func) support timestmamp(datetime, zone), date(datetime,zone)
URL: https://github.com/apache/doris/pull/40231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2764303151
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2343909735
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323743208
<details>
<summary>TPC-H: <b>Total hot run time: 37864 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e50795449641cf9e748b80fbb7033715babcb485, data reload: false
------ Round 1 ----------------------------------
q1 17621 4399 4319 4319
q2 2023 187 176 176
q3 11809 967 1166 967
q4 10528 760 846 760
q5 7732 2822 2825 2822
q6 229 138 145 138
q7 971 610 610 610
q8 9351 2087 2055 2055
q9 7599 6552 6535 6535
q10 6997 2220 2172 2172
q11 439 248 250 248
q12 408 230 232 230
q13 18743 3119 3087 3087
q14 292 236 234 234
q15 515 500 496 496
q16 585 526 492 492
q17 999 718 659 659
q18 7381 6851 6713 6713
q19 1387 1118 984 984
q20 675 321 325 321
q21 3910 2841 3178 2841
q22 1110 1005 1017 1005
Total cold run time: 111304 ms
Total hot run time: 37864 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4419 4334 4341 4334
q2 382 264 262 262
q3 2872 2714 2632 2632
q4 1919 1632 1646 1632
q5 5623 5699 5782 5699
q6 231 140 138 138
q7 2241 1824 1811 1811
q8 3323 3438 3489 3438
q9 8793 8793 8845 8793
q10 3541 3457 3389 3389
q11 631 494 487 487
q12 822 692 665 665
q13 15221 3205 3363 3205
q14 323 294 285 285
q15 543 500 484 484
q16 623 589 593 589
q17 1834 1585 1530 1530
q18 8164 7904 7942 7904
q19 1763 1628 1601 1601
q20 2170 1902 1999 1902
q21 5910 5459 5386 5386
q22 1143 1045 1056 1045
Total cold run time: 72491 ms
Total hot run time: 57211 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323621017
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323753359
<details>
<summary>TPC-DS: <b>Total hot run time: 192396 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e50795449641cf9e748b80fbb7033715babcb485, data reload: false
query1 1247 871 872 871
query2 6379 1921 1902 1902
query3 10602 3912 3910 3910
query4 58220 24084 23161 23161
query5 5401 511 524 511
query6 408 165 165 165
query7 5770 302 300 300
query8 286 209 210 209
query9 8794 2511 2503 2503
query10 496 300 266 266
query11 17180 15046 15187 15046
query12 157 101 100 100
query13 1553 402 384 384
query14 10489 7374 6979 6979
query15 231 186 180 180
query16 7544 508 469 469
query17 1126 582 564 564
query18 2054 299 297 297
query19 299 153 154 153
query20 125 116 115 115
query21 216 104 108 104
query22 4568 4468 4503 4468
query23 34566 33692 33294 33294
query24 5982 2829 2846 2829
query25 540 418 382 382
query26 682 155 152 152
query27 1783 284 279 279
query28 3704 2074 2063 2063
query29 697 413 409 409
query30 240 150 158 150
query31 943 755 768 755
query32 73 56 61 56
query33 457 292 290 290
query34 864 486 493 486
query35 831 742 738 738
query36 1075 926 934 926
query37 151 94 97 94
query38 3961 3861 3979 3861
query39 1490 1401 1387 1387
query40 201 117 117 117
query41 47 47 47 47
query42 115 98 96 96
query43 513 460 489 460
query44 1121 765 768 765
query45 203 165 169 165
query46 1097 723 723 723
query47 1902 1768 1802 1768
query48 382 304 298 298
query49 803 427 441 427
query50 814 422 430 422
query51 7220 7000 7063 7000
query52 101 90 90 90
query53 252 181 189 181
query54 566 465 453 453
query55 78 74 76 74
query56 271 259 260 259
query57 1170 1090 1085 1085
query58 225 231 235 231
query59 2984 2762 2830 2762
query60 299 269 300 269
query61 102 99 102 99
query62 768 650 653 650
query63 221 187 184 184
query64 2819 687 680 680
query65 3208 3139 3157 3139
query66 668 358 344 344
query67 15394 15256 15072 15072
query68 2973 578 591 578
query69 408 294 301 294
query70 1176 1145 1046 1046
query71 342 278 282 278
query72 5441 4029 3962 3962
query73 751 336 339 336
query74 9232 8950 8855 8855
query75 3440 2692 2714 2692
query76 1472 1039 938 938
query77 563 320 316 316
query78 9611 9080 9224 9080
query79 1034 524 524 524
query80 701 521 518 518
query81 461 239 235 235
query82 250 151 155 151
query83 176 149 152 149
query84 262 75 81 75
query85 694 298 285 285
query86 311 275 302 275
query87 4427 4393 4267 4267
query88 3222 2374 2350 2350
query89 386 289 296 289
query90 1914 200 197 197
query91 127 110 117 110
query92 69 58 56 56
query93 1042 536 537 536
query94 721 377 305 305
query95 340 260 263 260
query96 588 266 270 266
query97 3200 3041 3093 3041
query98 215 203 203 203
query99 1517 1266 1261 1261
Total cold run time: 301794 ms
Total hot run time: 192396 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323757676
<details>
<summary>ClickBench: <b>Total hot run time: 32.33 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e50795449641cf9e748b80fbb7033715babcb485, data reload: false
query1 0.04 0.04 0.04
query2 0.08 0.04 0.04
query3 0.23 0.05 0.05
query4 1.67 0.09 0.07
query5 0.50 0.49 0.49
query6 1.12 0.72 0.73
query7 0.02 0.02 0.01
query8 0.05 0.04 0.04
query9 0.55 0.49 0.50
query10 0.54 0.53 0.53
query11 0.16 0.11 0.11
query12 0.15 0.11 0.12
query13 0.61 0.59 0.58
query14 2.06 2.06 2.12
query15 0.90 0.84 0.81
query16 0.36 0.36 0.38
query17 1.04 1.07 1.06
query18 0.21 0.20 0.21
query19 1.84 1.78 1.78
query20 0.01 0.02 0.01
query21 15.39 0.66 0.66
query22 4.14 6.76 2.19
query23 18.28 1.40 1.36
query24 2.11 0.24 0.22
query25 0.16 0.08 0.09
query26 0.26 0.18 0.18
query27 0.08 0.08 0.07
query28 13.19 1.02 0.99
query29 12.61 3.36 3.29
query30 0.24 0.06 0.06
query31 2.87 0.41 0.39
query32 3.26 0.49 0.47
query33 2.92 3.00 3.02
query34 17.12 4.35 4.36
query35 4.47 4.41 4.44
query36 0.67 0.48 0.48
query37 0.19 0.16 0.14
query38 0.15 0.14 0.15
query39 0.05 0.04 0.04
query40 0.17 0.13 0.13
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.04 0.05 0.03
Total cold run time: 110.67 s
Total hot run time: 32.33 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2324577384
<details>
<summary>TPC-H: <b>Total hot run time: 37945 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c2b5ffe6e477a08dd81d8cffdbdbc917f8803a38, data reload: false
------ Round 1 ----------------------------------
q1 17604 4376 4295 4295
q2 2023 182 175 175
q3 11796 968 1111 968
q4 10514 685 798 685
q5 7776 2856 2730 2730
q6 227 137 136 136
q7 959 606 601 601
q8 9320 2062 2032 2032
q9 7268 6537 6497 6497
q10 6996 2219 2264 2219
q11 441 234 234 234
q12 396 217 225 217
q13 18902 3072 3045 3045
q14 273 233 239 233
q15 518 476 491 476
q16 620 534 496 496
q17 990 692 712 692
q18 7282 6840 6905 6840
q19 1384 1017 1002 1002
q20 668 337 331 331
q21 3867 2999 3017 2999
q22 1107 1042 1055 1042
Total cold run time: 110931 ms
Total hot run time: 37945 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4372 4281 4276 4276
q2 371 276 273 273
q3 2892 2597 2661 2597
q4 1907 1747 1611 1611
q5 5660 5647 5728 5647
q6 230 139 134 134
q7 2239 1824 1763 1763
q8 3306 3420 3449 3420
q9 8752 8794 8756 8756
q10 3567 3405 3388 3388
q11 606 502 497 497
q12 843 636 653 636
q13 15750 3186 3251 3186
q14 337 296 308 296
q15 563 489 489 489
q16 639 570 587 570
q17 1843 1555 1545 1545
q18 8018 7724 8068 7724
q19 1723 1463 1598 1463
q20 2116 1934 1918 1918
q21 5817 5386 5398 5386
q22 1152 1028 1035 1028
Total cold run time: 72703 ms
Total hot run time: 56603 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2324215449
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2324612900
<details>
<summary>ClickBench: <b>Total hot run time: 31.71 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c2b5ffe6e477a08dd81d8cffdbdbc917f8803a38, data reload: false
query1 0.05 0.04 0.04
query2 0.07 0.04 0.04
query3 0.22 0.05 0.04
query4 1.68 0.08 0.07
query5 0.51 0.49 0.49
query6 1.12 0.73 0.73
query7 0.02 0.01 0.02
query8 0.05 0.04 0.04
query9 0.56 0.47 0.48
query10 0.56 0.55 0.54
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.60 0.58 0.58
query14 2.03 2.06 2.11
query15 0.89 0.83 0.82
query16 0.38 0.37 0.38
query17 1.04 1.06 1.06
query18 0.21 0.20 0.19
query19 1.85 1.79 1.86
query20 0.01 0.02 0.01
query21 15.39 0.65 0.66
query22 4.01 8.53 1.55
query23 18.32 1.34 1.23
query24 2.10 0.22 0.23
query25 0.16 0.08 0.08
query26 0.27 0.18 0.18
query27 0.08 0.08 0.07
query28 13.21 1.01 1.00
query29 12.60 3.33 3.30
query30 0.24 0.06 0.06
query31 2.88 0.40 0.40
query32 3.25 0.49 0.49
query33 2.94 3.02 3.03
query34 16.99 4.36 4.41
query35 4.44 4.46 4.45
query36 0.65 0.49 0.51
query37 0.18 0.16 0.15
query38 0.15 0.14 0.15
query39 0.05 0.04 0.04
query40 0.15 0.13 0.13
query41 0.09 0.06 0.04
query42 0.06 0.04 0.05
query43 0.04 0.04 0.04
Total cold run time: 110.41 s
Total hot run time: 31.71 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2323750509
why we need this function and `convert_tz` is not enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](func) support timestmamp(datetime, zone), date(datetime,zone) [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #40231:
URL: https://github.com/apache/doris/pull/40231#issuecomment-2324479088
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org