You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/09 10:26:24 UTC

[GitHub] [zookeeper] ztzg opened a new pull request #1627: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data

ztzg opened a new pull request #1627:
URL: https://github.com/apache/zookeeper/pull/1627


   `InvalidSnapshotTest.testSnapshot` starts an instance of
   `ZooKeeperServer` on the version-controlled `resources/data/invalidsnap`
   directory, which, as a side-effect, \"fixes\" the following
   snapshot—which was broken on purpose (see ZOOKEEPER-367):
   
   `zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f`
   
   This status quo creates a number of problems:
   
   1.  It makes the test ineffective after the first run;
   2.  The file shows as modified in version control tools, which can be
       annoying;
   3.  The \"fixed\" snapshot can end up being committed by mistake,
       invalidating the test.
   
   (\#3 is not theoretical; that \"fixed\" snapshot frequently shows up in
   pull requests, and was recently merged into `master`.)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] arshadmohammad commented on pull request #1627: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data

Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1627:
URL: https://github.com/apache/zookeeper/pull/1627#issuecomment-794188000


   Merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] arshadmohammad closed pull request #1627: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data

Posted by GitBox <gi...@apache.org>.
arshadmohammad closed pull request #1627:
URL: https://github.com/apache/zookeeper/pull/1627


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] arshadmohammad commented on pull request #1627: ZOOKEEPER-4232: InvalidSnapshotTest corrupts its own test data

Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1627:
URL: https://github.com/apache/zookeeper/pull/1627#issuecomment-794117051


   "CI / mvn (full-build-cppunit-tests" failure seems not related to this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org