You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/16 15:11:18 UTC
[GitHub] [nuttx] dvosahlik opened a new pull request, #8152: Tm4 c1294 can char dev
dvosahlik opened a new pull request, #8152:
URL: https://github.com/apache/nuttx/pull/8152
## Summary
Implementation of TI Tiva TM4C1294 launchpad character device driver. The driver was taken over from the 1293 launchpad. Minor modifications were added to the configuration file. Bugfix of typo in the arch/tiva/tiva_can.c file
## Impact
Added support for missing CAN implementation on the TM4C1294XL launchpad
## Testing
The implementation was tested using TM4C1294XL launchpad against the PEAK USB CAN converter using can0 device on the lauchpad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] dvosahlik commented on a diff in pull request #8152: Tm4 c1294 can char dev
Posted by GitBox <gi...@apache.org>.
dvosahlik commented on code in PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#discussion_r1071920102
##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c1294-launchpad.h:
##########
@@ -77,6 +77,9 @@
# undef HAVE_I2CTOOL
#endif
+/* Define the procfs mounting point */
+#define TIVA_PROCFS_MOUNTPOINT "/proc"
Review Comment:
Done in [997e60a](https://github.com/apache/nuttx/pull/8152/commits/997e60aaddec0694f4ca171eeeae0adc57b66ab3)
##########
boards/arm/tiva/tm4c1294-launchpad/Kconfig:
##########
@@ -72,4 +72,46 @@ config TM4C1294_LAUNCHPAD_TIMER_ALTCLK
endif # TM4C1294_LAUNCHPAD_TIMER
endif # TIVA_TIMER32_PERIODIC
+config TM4C1294_LAUNCHPAD_JUMPERS_CAN
+ bool "Use CAN jumpers configuration"
+ default n
+ select TIVA_UART2
+ ---help---
+ If set, Nuttx will assume the jumpers JP4 and JP5 are set in CAN configuration.
Review Comment:
Done in [997e60a](https://github.com/apache/nuttx/pull/8152/commits/997e60aaddec0694f4ca171eeeae0adc57b66ab3)
##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c:
##########
@@ -0,0 +1,148 @@
+/****************************************************************************
+ * boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c
+ * Based heavily on stm32_can.c from the boards directory.
+ *
+ * Redistribution and use in source and binary forms, with or without
Review Comment:
Done in [997e60a](https://github.com/apache/nuttx/pull/8152/commits/997e60aaddec0694f4ca171eeeae0adc57b66ab3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8152: Tm4 c1294 can char dev
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#issuecomment-1385479786
@dvosahlik please squash the last patch to the second one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8152: Tm4 c1294 can char dev
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#discussion_r1071461526
##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c:
##########
@@ -0,0 +1,148 @@
+/****************************************************************************
+ * boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c
+ * Based heavily on stm32_can.c from the boards directory.
+ *
+ * Redistribution and use in source and binary forms, with or without
Review Comment:
need use apache copyright for new file, @dvosahlik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jerpelea merged pull request #8152: Tm4 c1294 can char dev
Posted by GitBox <gi...@apache.org>.
jerpelea merged PR #8152:
URL: https://github.com/apache/nuttx/pull/8152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8152: Tm4 c1294 can char dev
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#discussion_r1071461526
##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c:
##########
@@ -0,0 +1,148 @@
+/****************************************************************************
+ * boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c
+ * Based heavily on stm32_can.c from the boards directory.
+ *
+ * Redistribution and use in source and binary forms, with or without
Review Comment:
need use apache copyright for new file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] dvosahlik commented on pull request #8152: Tm4 c1294 can char dev
Posted by GitBox <gi...@apache.org>.
dvosahlik commented on PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#issuecomment-1385530796
@xiaoxiang781216, I did the squash as requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8152: Tm4 c1294 can char dev
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#discussion_r1071498054
##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c1294-launchpad.h:
##########
@@ -77,6 +77,9 @@
# undef HAVE_I2CTOOL
#endif
+/* Define the procfs mounting point */
+#define TIVA_PROCFS_MOUNTPOINT "/proc"
Review Comment:
Please add empty line after comment line
##########
boards/arm/tiva/tm4c1294-launchpad/Kconfig:
##########
@@ -72,4 +72,46 @@ config TM4C1294_LAUNCHPAD_TIMER_ALTCLK
endif # TM4C1294_LAUNCHPAD_TIMER
endif # TIVA_TIMER32_PERIODIC
+config TM4C1294_LAUNCHPAD_JUMPERS_CAN
+ bool "Use CAN jumpers configuration"
+ default n
+ select TIVA_UART2
+ ---help---
+ If set, Nuttx will assume the jumpers JP4 and JP5 are set in CAN configuration.
Review Comment:
```suggestion
If set, NuttX will assume the jumpers JP4 and JP5 are set in CAN configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org