[GitHub] [cordova-plugin-splashscreen] distinctdan opened a new pull request #213: (android) GH-180: Fixes nav and title bars still appearing when app is fullscreen

[GitBox <gi...@apache.org>]

distinctdan opened a new pull request #213: (android) GH-180: Fixes nav and title bars still appearing when app is fullscreen
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/213
 
 
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   This is a fix for https://github.com/apache/cordova-plugin-splashscreen/issues/180
   The issue is that when the app is supposed to be in fullscreen mode, the nav and title bars still display while the splashscreen is visible.
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Cordova's main activity currently doesn't set the fullscreen flag until it gets focus, so when we check it on plugin init, it's always false. I've added a fallback to read the `Fullscreen` preference if cordova hasn't set flags yet. Long term, I'm planning on doing a separate PR to the cordova-android repo to fix it so that it sets it in `onCreate` instead.
   
   Note: The issue is 90% fixed, but the nav and title bars still flash in briefly when the splashscreen hides. This is because cordova's activity hasn't set its view flags yet and hasn't gotten focus yet. The separate PR to cordova-android will fix this.
   
   ### Testing
   Ran `npm test`, manually tested the 3 cases of not fullscreen, Fullscreen, and FullscreenNotImmersive.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org