You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/05/03 13:12:45 UTC

[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui

svenvogel commented on issue #3294: Set default service offering over api and ui
URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-489090313
 
 
   @DaanHoogland we dont agree. we would prefer this functionality. we dont think its somehow like "clunky". "clunky" was it implemented before. we think it should be easier so set it for all types of system vms. this feature allow to set different type of system vm images. to get this a graphical menu is more user friendly than one value for each type of system vm in global settings. at the moment its a 
   
   > I would prefer to add a global setting to specify the default service offering for routers.
   > The service offering will be determined in findServiceOfferingId() in RouterDeploymentDefinition.java and VpcRouterDeploymentDefinition.java
   > 
   > If you do not mind, I can create a PR for it.
   
   what this means its determined in this functions? is there any functionality they breaks this? why it should set this in global setting when all other things for "offering" are set there?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services