You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/29 07:51:20 UTC

[GitHub] [airflow] ashb commented on a change in pull request #16700: Fix ``CeleryKubernetesExecutor``

ashb commented on a change in pull request #16700:
URL: https://github.com/apache/airflow/pull/16700#discussion_r660365084



##########
File path: airflow/jobs/backfill_job.py
##########
@@ -183,7 +186,8 @@ def __init__(
         self.conf = conf
         self.rerun_failed_tasks = rerun_failed_tasks
         self.run_backwards = run_backwards
-        super().__init__(*args, **kwargs)
+        self.executor = executor or ExecutorLoader.get_default_executor()
+        super().__init__(executor=self.executor, *args, **kwargs)

Review comment:
       How about instead of doing this we make `executor` a lazy/cached property on base job?
   
   That way it is not loaded until it is first accessed, which might fix the problem? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org