[GitHub] [lucene-solr] madrob commented on a change in pull request #1932: Reuse crypto keys in reference impl

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497719279



##########
File path: solr/core/src/java/org/apache/solr/security/PublicKeyHandler.java
##########
@@ -32,18 +32,22 @@
 public class PublicKeyHandler extends RequestHandlerBase {
   public static final String PATH = "/admin/info/key";
 
+  //This is an optimization for tests only
+  public static volatile CryptoKeys.RSAKeyPair REUSABLE_KEYPAIR ;

Review comment:
       Why not use the key-pair that's already on disk? See https://github.com/apache/lucene-solr/blob/master/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java#L289-L290




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org