You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by jm...@apache.org on 2010/03/05 19:51:28 UTC
svn commit: r919539 - in
/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math:
AbstractMatrix.java AbstractVector.java RandomAccessSparseVector.java
Author: jmannix
Date: Fri Mar 5 18:51:28 2010
New Revision: 919539
URL: http://svn.apache.org/viewvc?rev=919539&view=rev
Log:
Adding a few useful cases where throwing IndexException with the new constructor leads to easier debugging. This should be expanded to all uses of this exception, IMO.
Modified:
lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractMatrix.java
lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractVector.java
lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java
Modified: lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractMatrix.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractMatrix.java?rev=919539&r1=919538&r2=919539&view=diff
==============================================================================
--- lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractMatrix.java (original)
+++ lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractMatrix.java Fri Mar 5 18:51:28 2010
@@ -408,7 +408,7 @@
int[] c = size();
int[] o = other.size();
if (c[COL] != o[ROW]) {
- throw new CardinalityException();
+ throw new CardinalityException(c[COL], o[ROW]);
}
Matrix result = like(c[ROW], o[COL]);
for (int row = 0; row < c[ROW]; row++) {
Modified: lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractVector.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractVector.java?rev=919539&r1=919538&r2=919539&view=diff
==============================================================================
--- lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractVector.java (original)
+++ lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/AbstractVector.java Fri Mar 5 18:51:28 2010
@@ -350,7 +350,7 @@
if (index >= 0 && index < size()) {
setQuick(index, value);
} else {
- throw new IndexException();
+ throw new IndexException(index, size());
}
}
Modified: lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java?rev=919539&r1=919538&r2=919539&view=diff
==============================================================================
--- lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java (original)
+++ lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java Fri Mar 5 18:51:28 2010
@@ -265,7 +265,7 @@
@Override
public void addTo(Vector v) {
if (v.size() != size()) {
- throw new CardinalityException();
+ throw new CardinalityException(size(), v.size());
}
values.forEachPair(new AddToVector(v));
}