You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/01/08 19:50:11 UTC
[kudu-CR] mini cluster: Remove tablet server index by uuid() from interface
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8963
to review the following change.
Change subject: mini_cluster: Remove tablet_server_index_by_uuid() from interface
......................................................................
mini_cluster: Remove tablet_server_index_by_uuid() from interface
The tablet_server_index_by_uuid() method, which common to the
InternalMiniCluster and ExternalMiniCluster, isn't really useful from
the parent interface (MiniCluster) and isn't compatible with a
MixedMiniCluster that I'm working on. Let's just remove it from the pure
virtual parent interface.
Change-Id: I67d25278ee8c2b9379ed83008f162d8ac36271ab
---
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/mini-cluster/mini_cluster.h
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8963/1
--
To view, visit http://gerrit.cloudera.org:8080/8963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67d25278ee8c2b9379ed83008f162d8ac36271ab
Gerrit-Change-Number: 8963
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] mini cluster: Remove tablet server index by uuid() from interface
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8963 )
Change subject: mini_cluster: Remove tablet_server_index_by_uuid() from interface
......................................................................
mini_cluster: Remove tablet_server_index_by_uuid() from interface
The tablet_server_index_by_uuid() method, which common to the
InternalMiniCluster and ExternalMiniCluster, isn't really useful from
the parent interface (MiniCluster) and isn't compatible with a
MixedMiniCluster that I'm working on. Let's just remove it from the pure
virtual parent interface.
Change-Id: I67d25278ee8c2b9379ed83008f162d8ac36271ab
Reviewed-on: http://gerrit.cloudera.org:8080/8963
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/mini-cluster/mini_cluster.h
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I67d25278ee8c2b9379ed83008f162d8ac36271ab
Gerrit-Change-Number: 8963
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] mini cluster: Remove tablet server index by uuid() from interface
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8963 )
Change subject: mini_cluster: Remove tablet_server_index_by_uuid() from interface
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d25278ee8c2b9379ed83008f162d8ac36271ab
Gerrit-Change-Number: 8963
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Jan 2018 02:43:03 +0000
Gerrit-HasComments: No
[kudu-CR] mini cluster: Remove tablet server index by uuid() from interface
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8963 )
Change subject: mini_cluster: Remove tablet_server_index_by_uuid() from interface
......................................................................
Patch Set 1: Code-Review+1
Looks good to me; but it seems IWYU has some warnings.
--
To view, visit http://gerrit.cloudera.org:8080/8963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d25278ee8c2b9379ed83008f162d8ac36271ab
Gerrit-Change-Number: 8963
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 08 Jan 2018 20:33:08 +0000
Gerrit-HasComments: No