You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ol...@apache.org on 2009/04/08 01:41:29 UTC

svn commit: r763039 - in /continuum/trunk: continuum-release/src/main/java/org/apache/continuum/release/phase/AbstractContinuumRunGoalsPhase.java continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java

Author: olamy
Date: Tue Apr  7 23:41:28 2009
New Revision: 763039

URL: http://svn.apache.org/viewvc?rev=763039&view=rev
Log:
add TODO FIXME

Modified:
    continuum/trunk/continuum-release/src/main/java/org/apache/continuum/release/phase/AbstractContinuumRunGoalsPhase.java
    continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java

Modified: continuum/trunk/continuum-release/src/main/java/org/apache/continuum/release/phase/AbstractContinuumRunGoalsPhase.java
URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-release/src/main/java/org/apache/continuum/release/phase/AbstractContinuumRunGoalsPhase.java?rev=763039&r1=763038&r2=763039&view=diff
==============================================================================
--- continuum/trunk/continuum-release/src/main/java/org/apache/continuum/release/phase/AbstractContinuumRunGoalsPhase.java (original)
+++ continuum/trunk/continuum-release/src/main/java/org/apache/continuum/release/phase/AbstractContinuumRunGoalsPhase.java Tue Apr  7 23:41:28 2009
@@ -50,6 +50,9 @@
      */
     private InstallationService installationService;
 
+    /**
+     * TODO olamy use maven-invoker with an installation (jdk, mvn path, env var)
+     */
     public ReleaseResult execute( ReleaseDescriptor releaseDescriptor, File workingDirectory,
                                   String additionalArguments )
         throws ReleaseExecutionException

Modified: continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java
URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java?rev=763039&r1=763038&r2=763039&view=diff
==============================================================================
--- continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java (original)
+++ continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java Tue Apr  7 23:41:28 2009
@@ -166,6 +166,10 @@
         return SUCCESS;
     }
 
+    /**
+     * FIXME olamy is it really the good place to do that ? should be moved to continuum-release
+     * TODO handle remoteTagging  
+     */
     private void getReleasePluginParameters( String workingDirectory, String pomFilename )
         throws Exception
     {