You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Claus Ibsen <cl...@gmail.com> on 2019/03/01 10:38:48 UTC
Re: [camel-3] - core OSGi / XML
Hi
Yeah now that we have a core sub-folder, we can likely move them in there.
On Fri, Mar 1, 2019 at 11:25 AM Francois Papon
<fr...@openobject.fr> wrote:
>
> Hi,
>
> I see on master that this modules are under the "components" module:
>
> - camel-core-osgi
>
> - camel-core-xml
>
> Is there a reason to not put them under the "core" module?
>
> Regards,
>
> --
> François Papon
> fpapon@apache.org
>
>
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: [camel-3] - core OSGi / XML
Posted by Francois Papon <fr...@openobject.fr>.
Ok,
I created the Jira:
https://issues.apache.org/jira/browse/CAMEL-13275
I will push the PR for review.
Regards,
François Papon
fpapon@apache.org
Le 01/03/2019 à 14:50, Claus Ibsen a écrit :
> Hi
>
> Yeah but mind that moving them is not as easy, as the build assumes
> they are in the components folder. So you need to adjust
> camel-blueprint and camel-spring too, and also in the
> camel-package-maven-plugin some some code for dealing with these 2
> module names.
>
> I suggest to log a JIRA and then work on the PR
>
> On Fri, Mar 1, 2019 at 11:42 AM Francois Papon
> <fr...@openobject.fr> wrote:
>> Ok,
>>
>> Can I push a PR for this?
>>
>> Regards,
>>
>> François Papon
>> fpapon@apache.org
>>
>> Le 01/03/2019 à 14:38, Claus Ibsen a écrit :
>>> Hi
>>>
>>> Yeah now that we have a core sub-folder, we can likely move them in there.
>>>
>>>
>>> On Fri, Mar 1, 2019 at 11:25 AM Francois Papon
>>> <fr...@openobject.fr> wrote:
>>>> Hi,
>>>>
>>>> I see on master that this modules are under the "components" module:
>>>>
>>>> - camel-core-osgi
>>>>
>>>> - camel-core-xml
>>>>
>>>> Is there a reason to not put them under the "core" module?
>>>>
>>>> Regards,
>>>>
>>>> --
>>>> François Papon
>>>> fpapon@apache.org
>>>>
>>>>
>
>
Re: [camel-3] - core OSGi / XML
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Yeah but mind that moving them is not as easy, as the build assumes
they are in the components folder. So you need to adjust
camel-blueprint and camel-spring too, and also in the
camel-package-maven-plugin some some code for dealing with these 2
module names.
I suggest to log a JIRA and then work on the PR
On Fri, Mar 1, 2019 at 11:42 AM Francois Papon
<fr...@openobject.fr> wrote:
>
> Ok,
>
> Can I push a PR for this?
>
> Regards,
>
> François Papon
> fpapon@apache.org
>
> Le 01/03/2019 à 14:38, Claus Ibsen a écrit :
> > Hi
> >
> > Yeah now that we have a core sub-folder, we can likely move them in there.
> >
> >
> > On Fri, Mar 1, 2019 at 11:25 AM Francois Papon
> > <fr...@openobject.fr> wrote:
> >> Hi,
> >>
> >> I see on master that this modules are under the "components" module:
> >>
> >> - camel-core-osgi
> >>
> >> - camel-core-xml
> >>
> >> Is there a reason to not put them under the "core" module?
> >>
> >> Regards,
> >>
> >> --
> >> François Papon
> >> fpapon@apache.org
> >>
> >>
> >
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: [camel-3] - core OSGi / XML
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
It sounds good to me.
Regards
JB
Le 1 mars 2019 à 11:42, à 11:42, Francois Papon <fr...@openobject.fr> a écrit:
>Ok,
>
>Can I push a PR for this?
>
>Regards,
>
>François Papon
>fpapon@apache.org
>
>Le 01/03/2019 à 14:38, Claus Ibsen a écrit :
>> Hi
>>
>> Yeah now that we have a core sub-folder, we can likely move them in
>there.
>>
>>
>> On Fri, Mar 1, 2019 at 11:25 AM Francois Papon
>> <fr...@openobject.fr> wrote:
>>> Hi,
>>>
>>> I see on master that this modules are under the "components" module:
>>>
>>> - camel-core-osgi
>>>
>>> - camel-core-xml
>>>
>>> Is there a reason to not put them under the "core" module?
>>>
>>> Regards,
>>>
>>> --
>>> François Papon
>>> fpapon@apache.org
>>>
>>>
>>
Re: [camel-3] - core OSGi / XML
Posted by Francois Papon <fr...@openobject.fr>.
Ok,
Can I push a PR for this?
Regards,
François Papon
fpapon@apache.org
Le 01/03/2019 à 14:38, Claus Ibsen a écrit :
> Hi
>
> Yeah now that we have a core sub-folder, we can likely move them in there.
>
>
> On Fri, Mar 1, 2019 at 11:25 AM Francois Papon
> <fr...@openobject.fr> wrote:
>> Hi,
>>
>> I see on master that this modules are under the "components" module:
>>
>> - camel-core-osgi
>>
>> - camel-core-xml
>>
>> Is there a reason to not put them under the "core" module?
>>
>> Regards,
>>
>> --
>> François Papon
>> fpapon@apache.org
>>
>>
>