You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "smjn (via GitHub)" <gi...@apache.org> on 2024/09/01 07:10:40 UTC

Re: [PR] KAFKA-17367: Share coordinator impl. Broker side code. [2/N] [kafka]

smjn commented on code in PR #17011:
URL: https://github.com/apache/kafka/pull/17011#discussion_r1739991289


##########
core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala:
##########
@@ -38,7 +38,8 @@ import org.apache.kafka.common.security.auth.{KafkaPrincipal, KafkaPrincipalSerd
 import org.apache.kafka.common.utils.{SecurityUtils, Utils}
 import org.apache.kafka.coordinator.transaction.TransactionLogConfigs
 import org.apache.kafka.coordinator.group.{GroupCoordinator, GroupCoordinatorConfig}
-import org.apache.kafka.server.config.ServerConfigs
+import org.apache.kafka.coordinator.share.ShareCoordinator
+import org.apache.kafka.server.config.{ServerConfigs, ShareCoordinatorConfig}

Review Comment:
   Yes, there are some other interfaces and classes which need to be moved. 
   I will raise a separate PR for that to not pollute this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org