[GitHub] [kylin] zhangxiang17 commented on a change in pull request #933: KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration

[GitBox <gi...@apache.org>]

zhangxiang17 commented on a change in pull request #933:  KYLIN-4249:DistributedScheduler can selectively assign task nodes according to cube extra configuration
URL: https://github.com/apache/kylin/pull/933#discussion_r360863423
 
 

 ##########
 File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##########
 @@ -2282,4 +2282,33 @@ public int getStaleJobThresholdInDays() {
         return Integer.parseInt(getOptional("kylin.tool.health-check.stale-job-threshold-days", "30"));
     }
 
+    /**
+     * get assigned server array, which a empty string array in default
+     * @return
+     */
+    public String[] getAssignedServers() {
+        return getOptionalStringArray("kylin.cube.schedule.assigned-servers", new String[] {});
+    }
+
+    /**
+     * Determine if the target node is in the assigned node
+     * @param targetServers target task servers
+     * @return
+     */
+    public Boolean isOnAssignedServer(String... targetServers) {
 
 Review comment:
   I adjusted the config position and changed 'Boolean' to boolean just now, and finally i rebased this commit, could you review it again?:(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services