You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/18 05:41:07 UTC
[GitHub] [pulsar] tjiuming opened a new pull request, #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
tjiuming opened a new pull request, #16641:
URL: https://github.com/apache/pulsar/pull/16641
Fixes #14705
### Motivation
add document for bookkeeper configuration `skipListSizeLimit`
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on a diff in pull request #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #16641:
URL: https://github.com/apache/pulsar/pull/16641#discussion_r925277927
##########
site2/docs/reference-configuration.md:
##########
@@ -125,6 +125,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|dbStorage_rocksDB_numLevels||-1|
|dbStorage_rocksDB_numFilesInLevel0||4|
|dbStorage_rocksDB_maxSizeInLevel1MB||256|
+|skipListSizeLimit|Heap memory limitation of `EntryMemTable`, The `EntryMemTable` holds in-memory representation to the entries not-yet flushed. When asked to flush, current EntrySkipList is moved to snapshot and is cleared.|64MB|
Review Comment:
Users can check the documentation in `conf/bookkeeper.conf` to get more information. We'd better not expose that unused configuration on the Website, which will make other users confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on a diff in pull request #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
Posted by GitBox <gi...@apache.org>.
tjiuming commented on code in PR #16641:
URL: https://github.com/apache/pulsar/pull/16641#discussion_r925286886
##########
site2/docs/reference-configuration.md:
##########
@@ -125,6 +125,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|dbStorage_rocksDB_numLevels||-1|
|dbStorage_rocksDB_numFilesInLevel0||4|
|dbStorage_rocksDB_maxSizeInLevel1MB||256|
+|skipListSizeLimit|Heap memory limitation of `EntryMemTable`, The `EntryMemTable` holds in-memory representation to the entries not-yet flushed. When asked to flush, current EntrySkipList is moved to snapshot and is cleared.|64MB|
Review Comment:
OK, I'll close the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on a diff in pull request #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
Posted by GitBox <gi...@apache.org>.
tjiuming commented on code in PR #16641:
URL: https://github.com/apache/pulsar/pull/16641#discussion_r925266175
##########
site2/docs/reference-configuration.md:
##########
@@ -125,6 +125,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|dbStorage_rocksDB_numLevels||-1|
|dbStorage_rocksDB_numFilesInLevel0||4|
|dbStorage_rocksDB_maxSizeInLevel1MB||256|
+|skipListSizeLimit|Heap memory limitation of `EntryMemTable`, The `EntryMemTable` holds in-memory representation to the entries not-yet flushed. When asked to flush, current EntrySkipList is moved to snapshot and is cleared.|64MB|
Review Comment:
There are `skipListArenaChunkSize` and `skipListArenaMaxAllocSize` in the reference-config, and it's all for `EntryMemTable`, I think whether it's recommended or not, add the configuration into reference-config is required, in case of someone to ask it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming closed pull request #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
Posted by GitBox <gi...@apache.org>.
tjiuming closed pull request #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
URL: https://github.com/apache/pulsar/pull/16641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on pull request #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #16641:
URL: https://github.com/apache/pulsar/pull/16641#issuecomment-1186789309
@momo-jun @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on a diff in pull request #16641: [storage][config][doc] add `skipListSizeLimit` configuration doc of bookkeeper
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #16641:
URL: https://github.com/apache/pulsar/pull/16641#discussion_r925254911
##########
site2/docs/reference-configuration.md:
##########
@@ -125,6 +125,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|dbStorage_rocksDB_numLevels||-1|
|dbStorage_rocksDB_numFilesInLevel0||4|
|dbStorage_rocksDB_maxSizeInLevel1MB||256|
+|skipListSizeLimit|Heap memory limitation of `EntryMemTable`, The `EntryMemTable` holds in-memory representation to the entries not-yet flushed. When asked to flush, current EntrySkipList is moved to snapshot and is cleared.|64MB|
Review Comment:
This configuration is for `sortedLedgerStroage`, it won't work for `dbLedgerStorage`.
However, Pulsar uses dbLedgerStorage by default, and we are not recommended users to use `sortedLedgerStorage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org