You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by rs...@apache.org on 2019/03/15 15:36:31 UTC

[kafka] branch trunk updated: KAFKA-8091; Use commitSync to check connection failure in listener update test (#6450)

This is an automated email from the ASF dual-hosted git repository.

rsivaram pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new a6691fb  KAFKA-8091; Use commitSync to check connection failure in listener update test (#6450)
a6691fb is described below

commit a6691fb79e2c55b325513710c5e6e34e8dd4961e
Author: Rajini Sivaram <ra...@googlemail.com>
AuthorDate: Fri Mar 15 15:36:22 2019 +0000

    KAFKA-8091; Use commitSync to check connection failure in listener update test (#6450)
    
    The use of consumer.poll() made the test flaky since in some cases, it doesn't wait for coordinator connection.
    
    Reviewers: Manikumar Reddy <ma...@gmail.com>
---
 .../integration/kafka/server/DynamicBrokerReconfigurationTest.scala     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala b/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
index d1427b2..c14f41e 100644
--- a/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
+++ b/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
@@ -1315,7 +1315,7 @@ class DynamicBrokerReconfigurationTest extends ZooKeeperTestHarness with SaslSet
     executors += executor
     val future = executor.submit(new Runnable() {
       def run() {
-        assertEquals(0, consumer.poll(100).count)
+        consumer.commitSync()
       }
     })
     verifyTimeout(future)