You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Trevor Pounds (JIRA)" <ji...@apache.org> on 2008/06/17 17:51:00 UTC

[jira] Created: (AMQ-1804) ConnectionFactory classes shuld have XBean support

ConnectionFactory classes shuld have XBean support
--------------------------------------------------

                 Key: AMQ-1804
                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
             Project: ActiveMQ
          Issue Type: Improvement
    Affects Versions: 5.1.0, 4.1.2
            Reporter: Trevor Pounds
            Priority: Minor
             Fix For: 4.1.3, 5.2.0


It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.

{code:xml|title=current}
<bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
   <property name="connectionFactory">
      <bean class="org.apache.activemq.ActiveMQConnectionFactory">
         <property name="brokerURL">
            <value>tcp://localhost:61616</value>
         </property>
      </bean>
   </property>
</bean>
{code}

vs

{code:xml|title=improved}
<pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
<connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (AMQ-1804) ConnectionFactory classes should have XBean support

Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Pounds reopened AMQ-1804:
--------------------------------


Reopening ticket due to xbean name mapping conflict that may cause problems for some users.  I propose either removing the xbean mapping from the org.apache.activemq.ActiveMQConectionFactory class or removing the org.apache.activemq.spring.ActiveMQConnectionFactory class.  Do we need both of these classes?

> ConnectionFactory classes should have XBean support
> ---------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Assignee: Rob Davies
>            Priority: Minor
>             Fix For: 5.2.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1804) ConnectionFactory classes should have XBean support

Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Pounds updated AMQ-1804:
-------------------------------

    Summary: ConnectionFactory classes should have XBean support  (was: ConnectionFactory classes shuld have XBean support)

> ConnectionFactory classes should have XBean support
> ---------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Assignee: Rob Davies
>            Priority: Minor
>             Fix For: 5.2.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-1804) ConnectionFactory classes shuld have XBean support

Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43568#action_43568 ] 

Trevor Pounds commented on AMQ-1804:
------------------------------------

I see this has already been done for the ActiveMQConnectionFactory.  This really only needs to be done for the PooledConnectionFactory object.

> ConnectionFactory classes shuld have XBean support
> --------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Priority: Minor
>             Fix For: 4.1.3, 5.2.0
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (AMQ-1804) ConnectionFactory classes shuld have XBean support

Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43568#action_43568 ] 

tpounds edited comment on AMQ-1804 at 6/18/08 1:52 PM:
-------------------------------------------------------------

I see this has already been done for the ActiveMQConnectionFactory.  This really only needs to be done for the PooledConnectionFactory class.  I will try to provide a patch for this ASAP.

      was (Author: tpounds):
    I see this has already been done for the ActiveMQConnectionFactory.  This really only needs to be done for the PooledConnectionFactory object.
  
> ConnectionFactory classes shuld have XBean support
> --------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Priority: Minor
>             Fix For: 4.1.3, 5.2.0
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AMQ-1804) ConnectionFactory classes shuld have XBean support

Posted by "Rob Davies (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Davies reassigned AMQ-1804:
-------------------------------

    Assignee: Rob Davies

> ConnectionFactory classes shuld have XBean support
> --------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Assignee: Rob Davies
>            Priority: Minor
>             Fix For: 5.2.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1804) ConnectionFactory classes should have XBean support

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated AMQ-1804:
----------------------------

    Fix Version/s: 5.3.0
                       (was: 5.2.0)

> ConnectionFactory classes should have XBean support
> ---------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Assignee: Rob Davies
>            Priority: Minor
>             Fix For: 5.3.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1804) ConnectionFactory classes shuld have XBean support

Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Pounds updated AMQ-1804:
-------------------------------

    Attachment: r669289.diff

Attaching simple patch to provide xbean support for PooledConnectionFactory class

> ConnectionFactory classes shuld have XBean support
> --------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Priority: Minor
>             Fix For: 4.1.3, 5.2.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-1804) ConnectionFactory classes shuld have XBean support

Posted by "Trevor Pounds (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43609#action_43609 ] 

Trevor Pounds commented on AMQ-1804:
------------------------------------

Rob, I noticed that the org.apache.activemq.ActiveMQConnectionFactory class already has an XBean configuration (with the same element name) in the class org.apache.activemq.spring.ActiveMQConnectionFactory, albeit with a bit more configuration that supports Spring directly.   This may produce undesired results in the future in some configurations (i.e. classloading similar to something that happened in AMQ-1345).

> ConnectionFactory classes shuld have XBean support
> --------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Assignee: Rob Davies
>            Priority: Minor
>             Fix For: 5.2.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-1804) ConnectionFactory classes shuld have XBean support

Posted by "Rob Davies (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Davies resolved AMQ-1804.
-----------------------------

    Fix Version/s:     (was: 4.1.3)
       Resolution: Fixed

Fixed by SVN revision 669558 and 669555 
We currently don't have plans for a 4.1.3 release

> ConnectionFactory classes shuld have XBean support
> --------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Assignee: Rob Davies
>            Priority: Minor
>             Fix For: 5.2.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-1804) ConnectionFactory classes should have XBean support

Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dejan Bosanac resolved AMQ-1804.
--------------------------------

    Resolution: Fixed

Removed xbean mapping from org.apache.activemq.ActiveMQConectionFactory in SVN revision 792884

> ConnectionFactory classes should have XBean support
> ---------------------------------------------------
>
>                 Key: AMQ-1804
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1804
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 4.1.2, 5.1.0
>            Reporter: Trevor Pounds
>            Assignee: Rob Davies
>            Priority: Minor
>             Fix For: 5.3.0
>
>         Attachments: r669289.diff
>
>
> It would be nice to have certain objects deriving from javax.jms.ConnectionFactory to provide XBean binding support.  This would really clean up xbean configurations utilizing ActiveMQ connection factories.
> {code:xml|title=current}
> <bean id="pooledFactory" class="org.apache.activemq.pool.PooledConnectionFactory" destroy-method="stop">
>    <property name="connectionFactory">
>       <bean class="org.apache.activemq.ActiveMQConnectionFactory">
>          <property name="brokerURL">
>             <value>tcp://localhost:61616</value>
>          </property>
>       </bean>
>    </property>
> </bean>
> {code}
> vs
> {code:xml|title=improved}
> <pooledConnectionFactory id="pooledFactory" destroy-method="stop" connectionFactory="#connectionFactory"/>
> <connectionFactory id="connectionFactory" brokerURL="tcp://localhost:61616"/>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.