You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/11 16:20:19 UTC

[GitHub] potiuk opened a new pull request #4489: [AIRFLOW-3676] Add required permission to CloudSQL export/import example

potiuk opened a new pull request #4489: [AIRFLOW-3676] Add required permission to CloudSQL export/import example
URL: https://github.com/apache/airflow/pull/4489
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3676
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   There is an extra permission needed (Write! to bucket) in order to run
   Import operation for Google Cloud SQL. It might sounds pretty
   non-obvious to need a write permission when you import
   data from GCP bucket, but this is required.
   
   It's not well documented but you can find it in description here:
   
   https://cloud.google.com/sql/docs/mysql/import-export/importing#csv-reqs
   
   (Click on the GCLOUD (2ND GEN)) and you will see that you need it:
   
   Add the service account to the bucket ACL as a writer:
   
   gsutil acl ch -u [SERVICE_ACCOUNT_ADDRESS]:W gs://[BUCKET_NAME]
   Add the service account to the import file as a reader:
   
   gsutil acl ch -u [SERVICE_ACCOUNT_ADDRESS]:R gs://[BUCKET_NAME]/[IMPORT_FILE_NAME]
   
   ### Tests
   
   - [x] My PR does not need testing for this extremely good reason:
   
   This is just an example/documentation change
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
   No new functionality
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services