You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rdblue (via GitHub)" <gi...@apache.org> on 2023/08/01 02:05:40 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #8072: Spark: Supports creating a branch on an empty table

rdblue commented on code in PR #8072:
URL: https://github.com/apache/iceberg/pull/8072#discussion_r1280040147


##########
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##########
@@ -83,6 +83,19 @@ public interface ManageSnapshots extends PendingUpdate<Snapshot> {
    */
   ManageSnapshots cherrypick(long snapshotId);
 
+  /**
+   * Create a new branch. The branch will point to current snapshot if the current snapshot is not
+   * NULL. Otherwise, the branch will point to a newly created empty snapshot.
+   *
+   * @param name branch name
+   * @return this for method chaining
+   * @throws IllegalArgumentException if a branch with the given name already exists

Review Comment:
   Would be nice to have a test for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org