You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by la...@apache.org on 2021/04/12 10:35:19 UTC

[impala] 02/03: IMPALA-10596: De-flake TestAdmissionControllerStress

This is an automated email from the ASF dual-hosted git repository.

laszlog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit aa2302e53b0ba9ab493025f3c8aedb5401fb2360
Author: Bikramjeet Vig <bi...@gmail.com>
AuthorDate: Mon Apr 5 20:24:19 2021 -0700

    IMPALA-10596: De-flake TestAdmissionControllerStress
    
    Currently some tests in TestAdmissionControllerStress fail because
    they rely on queries holding onto resources on backends till they
    are explicitly closed. This was done by keeping the query alive by
    fetching very limited rows in intervals. After results spooling was
    turned on by default, the queries started to finish early and
    released their resources on other backends which let queued queries
    to get admitted. This patch turns off result spooling for the queries
    to avoid this situation.
    
    Testing:
    Ran test in a loop on my local dev machine.
    
    Change-Id: I1594a82f507db8dc094d4441dd8739d037f974ff
    Reviewed-on: http://gerrit.cloudera.org:8080/17272
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/custom_cluster/test_admission_controller.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py
index 2b9ca02..4445942 100644
--- a/tests/custom_cluster/test_admission_controller.py
+++ b/tests/custom_cluster/test_admission_controller.py
@@ -1763,6 +1763,10 @@ class TestAdmissionControllerStress(TestAdmissionControllerBase):
 
           exec_options = self.vector.get_value('exec_option')
           exec_options.update(self.additional_query_options)
+          # Turning off result spooling allows us to better control query execution by
+          # controlling the number or rows fetched. This allows us to maintain resource
+          # usage among backends.
+          exec_options['spool_query_results'] = 0
           query = QUERY.format(self.query_num)
           self.query_state = 'SUBMITTING'
           client = self.impalad.service.create_beeswax_client()