You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/06/01 19:45:08 UTC
Re: Review Request 34644: Update existing lambdas to meet style guide
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34644/
-----------------------------------------------------------
(Updated June 1, 2015, 5:45 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-2670
https://issues.apache.org/jira/browse/MESOS-2670
Repository: mesos
Description
-------
Update existing lambdas to meet style guide
Diffs
-----
3rdparty/libprocess/src/tests/process_tests.cpp 67e582cc250a9767a389e2bd0cc68985477f3ffb
Diff: https://reviews.apache.org/r/34644/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 34644: Update existing lambdas to meet style guide
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34644/#review87146
-----------------------------------------------------------
Ship it!
Thanks for doing this! We'll clean up the nit when we commit.
3rdparty/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/34644/#comment139465>
Comments end with a period '.'
- Joris Van Remoortere
On June 1, 2015, 5:45 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34644/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 5:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Bugs: MESOS-2670
> https://issues.apache.org/jira/browse/MESOS-2670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update existing lambdas to meet style guide
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/process_tests.cpp 67e582cc250a9767a389e2bd0cc68985477f3ffb
>
> Diff: https://reviews.apache.org/r/34644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34644: Update existing lambdas to meet style guide
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34644/#review87150
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 1, 2015, 5:45 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34644/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 5:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Bugs: MESOS-2670
> https://issues.apache.org/jira/browse/MESOS-2670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update existing lambdas to meet style guide
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/process_tests.cpp 67e582cc250a9767a389e2bd0cc68985477f3ffb
>
> Diff: https://reviews.apache.org/r/34644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34644: Update existing lambdas to meet style guide
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34644/
-----------------------------------------------------------
(Updated June 1, 2015, 5:45 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-2670
https://issues.apache.org/jira/browse/MESOS-2670
Repository: mesos
Description
-------
Update existing lambdas to meet style guide
Diffs (updated)
-----
3rdparty/libprocess/src/tests/process_tests.cpp 67e582cc250a9767a389e2bd0cc68985477f3ffb
Diff: https://reviews.apache.org/r/34644/diff/
Testing
-------
Thanks,
haosdent huang