You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/15 19:02:52 UTC

[GitHub] safrooze commented on a change in pull request #12184: Fix a bug in CachedOP.

safrooze commented on a change in pull request #12184: Fix a bug in CachedOP.
URL: https://github.com/apache/incubator-mxnet/pull/12184#discussion_r210373938
 
 

 ##########
 File path: src/imperative/cached_op.cc
 ##########
 @@ -823,9 +823,10 @@ OpStatePtr CachedOp::DynamicForward(
 
   // If we are already recording, we don't need RunGraph to record all
   // computation again.
 
 Review comment:
   I recommend clarifying in the comment that "When CachedOp is inlining, RunGraph is in charge of recording the graph, otherwise we are in charge of recording and RunGraph shall not be recording".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services