You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2009/10/23 19:49:26 UTC

svn commit: r829144 - in /jakarta/jmeter/trunk/src/components/org/apache/jmeter: extractor/JSR223PostProcessor.java modifiers/JSR223PreProcessor.java

Author: sebb
Date: Fri Oct 23 17:49:25 2009
New Revision: 829144

URL: http://svn.apache.org/viewvc?rev=829144&view=rev
Log:
Unused imports
Tidy error handling

Modified:
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessor.java
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessor.java

Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessor.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessor.java?rev=829144&r1=829143&r2=829144&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessor.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessor.java Fri Oct 23 17:49:25 2009
@@ -37,19 +37,14 @@
 
     public void process() {
     	
-    	ScriptEngineManager sem = null;
-    	try {
-    		sem = getManager();
-    	} catch(Exception e) {
-    		e.printStackTrace();
-    	}
-    	
-    	if(sem == null) { return; }
-    	try {
+        try {
+        	ScriptEngineManager sem = getManager();
+        	if(sem == null) { return; }
     		processFileOrScript(sem);
-    	} catch (Exception e) {
-    		e.printStackTrace();
+        } catch (ScriptException e) {
+            log.warn("Problem in JSR223 script "+e);
+    	} catch (IOException e) {
+            log.warn("Problem in JSR223 script "+e);
 		}
-
     }
 }

Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessor.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessor.java?rev=829144&r1=829143&r2=829144&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessor.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessor.java Fri Oct 23 17:49:25 2009
@@ -18,7 +18,10 @@
 
 package org.apache.jmeter.modifiers;
 
+import java.io.IOException;
+
 import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
 
 import org.apache.jmeter.processor.PreProcessor;
 import org.apache.jmeter.testbeans.TestBean;
@@ -38,8 +41,10 @@
         	ScriptEngineManager sem = getManager();
         	if(sem == null) { return; }
         	processFileOrScript(sem);
-        } catch (Exception e) {
-        	log.warn("Problem in JSR223 script " + e);
+        } catch (ScriptException e) {
+            log.warn("Problem in JSR223 script "+e);
+        } catch (IOException e) {
+            log.warn("Problem in JSR223 script "+e);
 		}
     }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org