You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/02 12:15:52 UTC
[GitHub] [flink] wuchong opened a new pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
wuchong opened a new pull request #12441:
URL: https://github.com/apache/flink/pull/12441
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
As discussed in the JIRA issue, operators shouldn't update value object of state in the other processElement call. AppendOnlyTopNFunction doesn't follow this, and I have checked all the operators in table module, this should be the only one. All others either never update value obejct of state, or follow the get-update-put operation in a single processElement.
## Brief change log
- Always shallow copy the list value when putting it into `dataState`.
- Update `FailingCollectionSource` to fail after at least one element was checkpointed. This may uncover more failures like this one (but can't reproduce this problem all the time).
## Verifying this change
It is hard to be reproduced using existing tests. I reproduce the problem using @AHeise
s [commit](https://github.com/apache/flink/commit/c05a0d865989c9959047cebcf2cd68b3838cc699), and verified this fix manually.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
}, {
"hash" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639",
"triggerID" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5e43a378abf5461fb7b94ca77abe792f1fad661 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
}, {
"hash" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639",
"triggerID" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d341557869cbeeb7c220eba1d39037a63631df5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568)
* c5e43a378abf5461fb7b94ca77abe792f1fad661 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
}, {
"hash" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639",
"triggerID" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"triggerType" : "PUSH"
}, {
"hash" : "f29704003c481fdbb72a072fec9ddb2bf0bc3b72",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2684",
"triggerID" : "f29704003c481fdbb72a072fec9ddb2bf0bc3b72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f29704003c481fdbb72a072fec9ddb2bf0bc3b72 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2684)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-638137845
Okay I investigated `org.apache.flink.table.planner.runtime.stream.sql.OverWindowITCase#testRowTimeUnBoundedPartitionedRowsOver2`.
The issue in general is that the watermark is not coming from the source but from `EventTimeProcessOperator`. Since, it is not storing the watermark, the first watermark after recovery will be emitted quite late after the first element have been processed. Then some late elements may be processed before that and actually be emitted even though they shouldn't (since watermark is effectively 0).
Since this more related to the test setup than anything else, I'd recommend to store the last watermark in `EventTimeProcessOperator` during checkpointing and emit on recovery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-638038993
The actual changes LGTM.
However, Azure showed an error that was probably found by the different test setup. I'll investigate what's going on (I have a good test setup for these issues now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #12441:
URL: https://github.com/apache/flink/pull/12441#discussion_r434746169
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/utils/TimeTestUtil.scala
##########
@@ -52,14 +56,47 @@ object TimeTestUtil {
}
}
+ /**
+ * A streaming operator to emit records and watermark depends on the input data.
+ * The last emitted watermark will be stored in state to emit it again on recovery.
+ * This is necessary for late arrival testing with [[FailingCollectionSource]].
+ */
class EventTimeProcessOperator[T]
extends AbstractStreamOperator[T]
with OneInputStreamOperator[Either[(Long, T), Long], T] {
+ private var currentWatermark: Long = 0L
+ private var watermarkState: ListState[JLong] = _
+
+ override def snapshotState(context: StateSnapshotContext): Unit = {
+ super.snapshotState(context)
+ watermarkState.clear()
+ watermarkState.add(currentWatermark)
+ }
+
+ override def initializeState(context: StateInitializationContext): Unit = {
+ super.initializeState(context)
+ // use union list state to get the max watermark
+ watermarkState = context.getOperatorStateStore.getUnionListState(
Review comment:
What's the idea of using max watermark?
In the used test cases, the sources have only a DOP of 1 (at least from what I have seen). So it seems more complicated than necessary as the union state is actually not used with more than one element afaik.
Even if we have a DOP>1, it might even be harmful. Let's say we have two source subtask. By using the max watermark on all sources, we might declare some elements late, even though they are not, because we used the watermark of the other source subtasks.
I also haven't seen any indication that this class is used for rescaling. So union state might be over-engineered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-638761387
Thanks for the reviewing @AHeise . Will merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12441:
URL: https://github.com/apache/flink/pull/12441#discussion_r434984931
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/utils/TimeTestUtil.scala
##########
@@ -52,14 +56,47 @@ object TimeTestUtil {
}
}
+ /**
+ * A streaming operator to emit records and watermark depends on the input data.
+ * The last emitted watermark will be stored in state to emit it again on recovery.
+ * This is necessary for late arrival testing with [[FailingCollectionSource]].
+ */
class EventTimeProcessOperator[T]
extends AbstractStreamOperator[T]
with OneInputStreamOperator[Either[(Long, T), Long], T] {
+ private var currentWatermark: Long = 0L
+ private var watermarkState: ListState[JLong] = _
+
+ override def snapshotState(context: StateSnapshotContext): Unit = {
+ super.snapshotState(context)
+ watermarkState.clear()
+ watermarkState.add(currentWatermark)
+ }
+
+ override def initializeState(context: StateInitializationContext): Unit = {
+ super.initializeState(context)
+ // use union list state to get the max watermark
+ watermarkState = context.getOperatorStateStore.getUnionListState(
Review comment:
Thanks for pointing it out. I agree with you it's over-engineered. It is not simple in rescale case. I will use simple list state as we won't rescale in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
}, {
"hash" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639",
"triggerID" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"triggerType" : "PUSH"
}, {
"hash" : "f29704003c481fdbb72a072fec9ddb2bf0bc3b72",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2684",
"triggerID" : "f29704003c481fdbb72a072fec9ddb2bf0bc3b72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5e43a378abf5461fb7b94ca77abe792f1fad661 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639)
* f29704003c481fdbb72a072fec9ddb2bf0bc3b72 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2684)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-638146564
Wow, great thanks for the investigation. I just have time to look into this and your analysis makes sense to me. I will update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
}, {
"hash" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639",
"triggerID" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"triggerType" : "PUSH"
}, {
"hash" : "f29704003c481fdbb72a072fec9ddb2bf0bc3b72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f29704003c481fdbb72a072fec9ddb2bf0bc3b72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5e43a378abf5461fb7b94ca77abe792f1fad661 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2639)
* f29704003c481fdbb72a072fec9ddb2bf0bc3b72 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637512303
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 73b38c8ef83b559c54c66308b3b923e108e2ed86 (Tue Jun 02 12:34:19 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d341557869cbeeb7c220eba1d39037a63631df5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d341557869cbeeb7c220eba1d39037a63631df5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12441:
URL: https://github.com/apache/flink/pull/12441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
}, {
"hash" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c5e43a378abf5461fb7b94ca77abe792f1fad661",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d341557869cbeeb7c220eba1d39037a63631df5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568)
* c5e43a378abf5461fb7b94ca77abe792f1fad661 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12441: [FLINK-17918][table-blink] Fix AppendOnlyTopNFunction shouldn't mutate list value of MapState
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12441:
URL: https://github.com/apache/flink/pull/12441#issuecomment-637524540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568",
"triggerID" : "3d341557869cbeeb7c220eba1d39037a63631df5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d341557869cbeeb7c220eba1d39037a63631df5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2568)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org