You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/01/11 19:19:22 UTC
svn commit: r1432204 -
/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
Author: ggregory
Date: Fri Jan 11 18:19:22 2013
New Revision: 1432204
URL: http://svn.apache.org/viewvc?rev=1432204&view=rev
Log:
Local variable name should start with a lower case letter.
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java?rev=1432204&r1=1432203&r2=1432204&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java Fri Jan 11 18:19:22 2013
@@ -569,25 +569,25 @@ public class GifImageParser extends Imag
final int height = id.imageWidth;
final int width = id.imageHeight;
- List<String> Comments;
+ List<String> comments;
- Comments = getComments(blocks.blocks);
+ comments = getComments(blocks.blocks);
- final int BitsPerPixel = (bhi.colorResolution + 1);
- final ImageFormat Format = ImageFormat.IMAGE_FORMAT_GIF;
- final String FormatName = "GIF Graphics Interchange Format";
- final String MimeType = "image/gif";
+ final int bitsPerPixel = (bhi.colorResolution + 1);
+ final ImageFormat format = ImageFormat.IMAGE_FORMAT_GIF;
+ final String formatName = "GIF Graphics Interchange Format";
+ final String mimeType = "image/gif";
// we ought to count images, but don't yet.
- final int NumberOfImages = -1;
+ final int numberOfImages = -1;
final boolean isProgressive = id.interlaceFlag;
- final int PhysicalWidthDpi = 72;
- final float PhysicalWidthInch = (float) ((double) width / (double) PhysicalWidthDpi);
- final int PhysicalHeightDpi = 72;
- final float PhysicalHeightInch = (float) ((double) height / (double) PhysicalHeightDpi);
+ final int physicalWidthDpi = 72;
+ final float physicalWidthInch = (float) ((double) width / (double) physicalWidthDpi);
+ final int physicalHeightDpi = 72;
+ final float physicalHeightInch = (float) ((double) height / (double) physicalHeightDpi);
- final String FormatDetails = "Gif " + ((char) blocks.gifHeaderInfo.version1)
+ final String formatDetails = "Gif " + ((char) blocks.gifHeaderInfo.version1)
+ ((char) blocks.gifHeaderInfo.version2)
+ ((char) blocks.gifHeaderInfo.version3);
@@ -600,10 +600,10 @@ public class GifImageParser extends Imag
final int colorType = ImageInfo.COLOR_TYPE_RGB;
final String compressionAlgorithm = ImageInfo.COMPRESSION_ALGORITHM_LZW;
- final ImageInfo result = new ImageInfo(FormatDetails, BitsPerPixel, Comments,
- Format, FormatName, height, MimeType, NumberOfImages,
- PhysicalHeightDpi, PhysicalHeightInch, PhysicalWidthDpi,
- PhysicalWidthInch, width, isProgressive, isTransparent,
+ final ImageInfo result = new ImageInfo(formatDetails, bitsPerPixel, comments,
+ format, formatName, height, mimeType, numberOfImages,
+ physicalHeightDpi, physicalHeightInch, physicalWidthDpi,
+ physicalWidthInch, width, isProgressive, isTransparent,
usesPalette, colorType, compressionAlgorithm);
return result;