You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/08/04 11:47:36 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #610: [YUNIKORN-1899] Handle config reload in the event code
pbacsko opened a new pull request, #610:
URL: https://github.com/apache/yunikorn-core/pull/610
### What is this PR for?
We must consider the current configuration when sending out events. Right now, a boolean is initialzed only once and config reloads do not take effect.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [x] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1899
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #610: [YUNIKORN-1899] Handle config reload in the event code
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #610:
URL: https://github.com/apache/yunikorn-core/pull/610#issuecomment-1667186028
Filed a follow up for the missing unit tests for the utility code [YUNIKORN-1903](https://issues.apache.org/jira/browse/YUNIKORN-1903)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #610: [YUNIKORN-1899] Handle config reload in the event code
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #610:
URL: https://github.com/apache/yunikorn-core/pull/610#issuecomment-1665483985
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#610](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (51ade23) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/3133627d8a4831c93113186109d1bc28f179da20?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3133627) will **decrease** coverage by `0.63%`.
> Report is 1 commits behind head on master.
> The diff coverage is `65.28%`.
```diff
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 77.54% 76.91% -0.63%
==========================================
Files 77 77
Lines 12726 12879 +153
==========================================
+ Hits 9868 9906 +38
- Misses 2543 2633 +90
- Partials 315 340 +25
```
| [Files Changed](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/common/configs/configs.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3MuZ28=) | `85.18% <ø> (ø)` | |
| [pkg/common/utils.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi91dGlscy5nbw==) | `65.90% <0.00%> (-20.66%)` | :arrow_down: |
| [pkg/scheduler/objects/node\_events.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGVfZXZlbnRzLmdv) | `65.51% <0.00%> (-34.49%)` | :arrow_down: |
| [pkg/scheduler/objects/queue\_events.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlX2V2ZW50cy5nbw==) | `68.18% <0.00%> (-31.82%)` | :arrow_down: |
| [pkg/scheduler/objects/application\_events.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `69.62% <20.00%> (-30.38%)` | :arrow_down: |
| [pkg/events/event\_ringbuffer.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2V2ZW50cy9ldmVudF9yaW5nYnVmZmVyLmdv) | `100.00% <100.00%> (ø)` | |
| [pkg/events/event\_system.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/610?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2V2ZW50cy9ldmVudF9zeXN0ZW0uZ28=) | `97.41% <100.00%> (+2.77%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/610/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #610: [YUNIKORN-1899] Handle config reload in the event code
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #610: [YUNIKORN-1899] Handle config reload in the event code
URL: https://github.com/apache/yunikorn-core/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko commented on pull request #610: [YUNIKORN-1899] Handle config reload in the event code
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #610:
URL: https://github.com/apache/yunikorn-core/pull/610#issuecomment-1665663673
`utils.go` coverge report is misleading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org