[GitHub] [incubator-nuttx] michallenc edited a comment on pull request #2789: imxrt: fixed CAN error while sending larger amount of data

[GitBox <gi...@apache.org>]

michallenc edited a comment on pull request #2789:
URL: https://github.com/apache/incubator-nuttx/pull/2789#issuecomment-771169757


   > Hey @michallenc thank you for you contribution, by finding this issue with the ESR2 register, however when stress testing the CAN TX still dropped frames will occur. I've made an alternative fix, could you test that one?
   
   Hi @PetervdPerk-NXP, thank you for checking, your changes are working on my EVK, however it seems the received packages are mixed up:
   
   ```
     can4  123   [8]  50 00 00 00 00 00 00 00
     can4  123   [8]  4F 00 00 00 00 00 00 00
     can4  123   [8]  52 00 00 00 00 00 00 00
     can4  123   [8]  51 00 00 00 00 00 00 00
     can4  123   [8]  54 00 00 00 00 00 00 00
     can4  123   [8]  53 00 00 00 00 00 00 00
     can4  123   [8]  56 00 00 00 00 00 00 00
     can4  123   [8]  55 00 00 00 00 00 00 00
     can4  123   [8]  58 00 00 00 00 00 00 00
     can4  123   [8]  57 00 00 00 00 00 00 00
     can4  123   [8]  5A 00 00 00 00 00 00 00
     can4  123   [8]  59 00 00 00 00 00 00 00
     can4  123   [8]  5C 00 00 00 00 00 00 00
     can4  123   [8]  5B 00 00 00 00 00 00 00
     can4  123   [8]  5E 00 00 00 00 00 00 00
   ```
   
   Replacing if (!imxrt_txringfull(priv)) in function imxrt_txavail_work on line 1297 with registers the same way you did in  imxrt_txpoll seems to address this problem.
   
   ```
     can4  123   [8]  51 00 00 00 00 00 00 00
     can4  123   [8]  52 00 00 00 00 00 00 00
     can4  123   [8]  53 00 00 00 00 00 00 00
     can4  123   [8]  54 00 00 00 00 00 00 00
     can4  123   [8]  55 00 00 00 00 00 00 00
     can4  123   [8]  56 00 00 00 00 00 00 00
     can4  123   [8]  57 00 00 00 00 00 00 00
     can4  123   [8]  58 00 00 00 00 00 00 00
     can4  123   [8]  59 00 00 00 00 00 00 00
     can4  123   [8]  5A 00 00 00 00 00 00 00
     can4  123   [8]  5B 00 00 00 00 00 00 00
     can4  123   [8]  5C 00 00 00 00 00 00 00
     can4  123   [8]  5D 00 00 00 00 00 00 00
     can4  123   [8]  5E 00 00 00 00 00 00 00
     can4  123   [8]  5F 00 00 00 00 00 00 00
   ```
   
   Would you test that change in your code? If it does work with your board I will close this PR so you can push yours.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org