You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/06 13:37:10 UTC

[GitHub] [druid] LakshSingla edited a comment on pull request #12001: Intern RowSignature in DruidSchema to reduce its memory footprint

LakshSingla edited a comment on pull request #12001:
URL: https://github.com/apache/druid/pull/12001#issuecomment-986780710


   I have updated the latest benchmark to call refreshSegment repeatedly on an already present segment id. Till I don't use the Blackhole and State objects, the result of the benchmark is coming out to be similar with both interned and non interned usage. Therefore using JMH's Blackhole and State objects to consume and provide the parameters to the `refreshSegment` call. Following are the results:
   
   With interning:
   ```
   Benchmark                                   (iterations)  (numColumns)  Mode  Cnt        Score        Error  Units
   DruidSchemaAddSegmentBenchmark.addSegments         10000          1000  avgt   15  2170791.575 ± 364899.773  us/op
   ```
   
   Without interning:
   ```
   Benchmark                                   (iterations)  (numColumns)  Mode  Cnt        Score        Error  Units
   DruidSchemaAddSegmentBenchmark.addSegments         10000          1000  avgt   15  1714452.523 ± 126620.724  us/op
   ```
   
   The rows has 1000 columns, and the call to refresh segments is made 10000 times.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org