[jira] [Resolved] (TS-1524) 3.2.x - fix signed/unsigned compilation issues in Vec

["Igor Galić (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Galić resolved TS-1524.
----------------------------

    Resolution: Fixed

af17c34541eea8709b1221a5caf4fbe1584e78c5
                
> 3.2.x - fix signed/unsigned compilation issues in Vec
> -----------------------------------------------------
>
>                 Key: TS-1524
>                 URL: https://issues.apache.org/jira/browse/TS-1524
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cleanup, Core
>    Affects Versions: 3.3.0
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 3.2.3
>
>
> cc1plus: warnings being treated as errors
> Vec.h: In function ‘int main(int, char**)’:
> Vec.h:616: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false
> Vec.h:616: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false
> Alan says:
> It is a result of optimization in the call sequence in test_append that calls str.append(value,len) which calls reserve(length() + count). length() is inlined to a reference to n so the argument is treated as "n+count". This yields, in the reserve method at the bad line
>  if (n+count <= n)
> which leads to the warning/error you see. I don't see how to disable the error, though. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira