You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Asmita Mutgekar <as...@gmail.com> on 2023/12/14 09:36:32 UTC

Issue #21005

Hi Team,

I have picked Issue: Add documentation and improved errors for QueryFn in
MongoDbIO #21005
Did some initial analysis on code and came up with the solution below ;
1. For documentation it's straightforward to add classes that the method
can handle so i will be adding 2 classes that withQueryFn can handle.
2. For the split() method I am thinking of adding one check for if the
object is AggregationQuery similar to FindQuery. Will have an "else"
condition that will throw an exception saying "unknown type".

Let me know if I am going in the correct direction.

Thanks & Regards,
Asmita

Re: Issue #21005

Posted by John Casey via dev <de...@beam.apache.org>.
Hi Asmita,

Those both make sense to me, feel free to go ahead.

I'll be happy to review your PR when its ready

On Thu, Dec 14, 2023 at 11:44 AM Asmita Mutgekar <as...@gmail.com>
wrote:

> Hi Team,
>
> I have picked Issue: Add documentation and improved errors for QueryFn in
> MongoDbIO #21005
> Did some initial analysis on code and came up with the solution below ;
> 1. For documentation it's straightforward to add classes that the method
> can handle so i will be adding 2 classes that withQueryFn can handle.
> 2. For the split() method I am thinking of adding one check for if the
> object is AggregationQuery similar to FindQuery. Will have an "else"
> condition that will throw an exception saying "unknown type".
>
> Let me know if I am going in the correct direction.
>
> Thanks & Regards,
> Asmita
>