[GitHub] [iceberg] danielcweeks commented on a change in pull request #1788: AWS: add ACL support for S3FileIO

[GitBox <gi...@apache.org>]

danielcweeks commented on a change in pull request #1788:
URL: https://github.com/apache/iceberg/pull/1788#discussion_r529020010



##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -165,6 +177,11 @@ public AwsProperties(Map<String, String> properties) {
 
     this.s3fileIoStagingDirectory = PropertyUtil.propertyAsString(properties, S3FILEIO_STAGING_DIRECTORY,
         System.getProperty("java.io.tmpdir"));
+
+    String aclType = properties.get(S3FILEIO_ACL);
+    this.s3FileIoAcl = ObjectCannedACL.fromValue(aclType);
+    Preconditions.checkArgument(s3FileIoAcl == null || !s3FileIoAcl.equals(ObjectCannedACL.UNKNOWN_TO_SDK_VERSION),
+        "Cannot supported S3 CannedACL " + aclType);

Review comment:
       nit: did you mean "Unsupported S3 CannedACL"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org