You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ravi Prakash (JIRA)" <ji...@apache.org> on 2012/05/30 19:23:25 UTC
[jira] [Created] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Ravi Prakash created MAPREDUCE-4297:
---------------------------------------
Summary: Usersmap file in gridmix should not fail on empty lines
Key: MAPREDUCE-4297
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/gridmix
Affects Versions: 0.23.1
Reporter: Ravi Prakash
Assignee: Ravi Prakash
An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Ravi Prakash (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Prakash updated MAPREDUCE-4297:
------------------------------------
Attachment: MAPREDUCE-4297.patch
Thanks for pointing that out RaviG. This patch addresses your comment
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Ravi Prakash (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Prakash updated MAPREDUCE-4297:
------------------------------------
Attachment: MAPREDUCE-4297.patch
Thanks for reviewing this Bobby!
I wasn't sure because I was thinking a byte in Text might decode to whitespace but its getLength() could possibly not be 0. But you are right! We want to ignore those cases. I've removed that condition, and trimmed the strings before comparing and assigning.
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287368#comment-13287368 ]
Hudson commented on MAPREDUCE-4297:
-----------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #274 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/274/])
svn merge -c 1344763 FIXES: MAPREDUCE-4297. Usersmap file in gridmix should not fail on empty lines (Ravi Prakash via bobby) (Revision 1344765)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344765
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/docs/src/documentation/content/xdocs/gridmix.xml
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/RoundRobinUserResolver.java
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Ravi Prakash (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Prakash updated MAPREDUCE-4297:
------------------------------------
Status: Patch Available (was: Open)
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Ravi Prakash (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Prakash updated MAPREDUCE-4297:
------------------------------------
Attachment: MAPREDUCE-4297.patch
Simple enough patch. I ran TestUserResolve and it passed.
Not including a test because its a trivial fix
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287341#comment-13287341 ]
Hudson commented on MAPREDUCE-4297:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #1063 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1063/])
MAPREDUCE-4297. Usersmap file in gridmix should not fail on empty lines (Ravi Prakash via bobby) (Revision 1344763)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344763
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/src/docs/src/documentation/content/xdocs/gridmix.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/RoundRobinUserResolver.java
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Ravi Prakash (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Prakash updated MAPREDUCE-4297:
------------------------------------
Status: Patch Available (was: Open)
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-4297:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
2.0.1-alpha
0.23.3
Status: Resolved (was: Patch Available)
Thanks Ravi, +1 I put this into trunk, branch-2, and branch-0.23
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed MAPREDUCE-4297.
------------------------------------
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.2-alpha
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286710#comment-13286710 ]
Hudson commented on MAPREDUCE-4297:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2322 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2322/])
MAPREDUCE-4297. Usersmap file in gridmix should not fail on empty lines (Ravi Prakash via bobby) (Revision 1344763)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344763
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/src/docs/src/documentation/content/xdocs/gridmix.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/RoundRobinUserResolver.java
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286333#comment-13286333 ]
Ravi Gummadi commented on MAPREDUCE-4297:
-----------------------------------------
Code changes look good to me. But the comments/javadoc and the documentation in gridmix.xml mention that each line should be of the form user[,group]*. This needs to be changed as per this patch ?
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286665#comment-13286665 ]
Hudson commented on MAPREDUCE-4297:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #2305 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2305/])
MAPREDUCE-4297. Usersmap file in gridmix should not fail on empty lines (Ravi Prakash via bobby) (Revision 1344763)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344763
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/src/docs/src/documentation/content/xdocs/gridmix.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/RoundRobinUserResolver.java
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-4297:
-------------------------------------------
Status: Open (was: Patch Available)
Canceling patch so we can address the latest comments.
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286098#comment-13286098 ]
Hadoop QA commented on MAPREDUCE-4297:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530275/MAPREDUCE-4297.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2425//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2425//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2425//console
This message is automatically generated.
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286653#comment-13286653 ]
Hudson commented on MAPREDUCE-4297:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2377 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2377/])
MAPREDUCE-4297. Usersmap file in gridmix should not fail on empty lines (Ravi Prakash via bobby) (Revision 1344763)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344763
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/src/docs/src/documentation/content/xdocs/gridmix.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/RoundRobinUserResolver.java
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286652#comment-13286652 ]
Hadoop QA commented on MAPREDUCE-4297:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530398/MAPREDUCE-4297.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2428//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2428//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2428//console
This message is automatically generated.
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287425#comment-13287425 ]
Hudson commented on MAPREDUCE-4297:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #1097 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1097/])
MAPREDUCE-4297. Usersmap file in gridmix should not fail on empty lines (Ravi Prakash via bobby) (Revision 1344763)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344763
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/src/docs/src/documentation/content/xdocs/gridmix.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/RoundRobinUserResolver.java
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Fix For: 0.23.3, 2.0.1-alpha, 3.0.0
>
> Attachments: MAPREDUCE-4297.patch, MAPREDUCE-4297.patch, MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285985#comment-13285985 ]
Robert Joseph Evans commented on MAPREDUCE-4297:
------------------------------------------------
The patch makes it so truly empty lines are ignored, which is good.
But I have a couple of comments.
# {code}rawUgi.getLength() == 0{code} is no longer needed because it is the same as {code}rawUgi.toString().equals(""){code}
# I am just a bit conflicted on white space and I would like your opinion on it. An empty line is ignored but a line with a single space or a tab in it will result in a user named ' ' or '\t' which seems bad to me. Similarly a line with white space in front of or after a user name will result in exactly that a user name with white space in it. Do we want to even try to deal with this or not?
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4297) Usersmap file in gridmix should
not fail on empty lines
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285843#comment-13285843 ]
Hadoop QA commented on MAPREDUCE-4297:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530238/MAPREDUCE-4297.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-tools/hadoop-gridmix.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2424//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2424//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-gridmix.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2424//console
This message is automatically generated.
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira