You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 12:34:30 UTC
[GitHub] [arrow] phillipleblanc opened a new pull request, #13065: ARROW-16456: [Go] Fix RecordBuilder UnmarshalJSON when extra fields are present
phillipleblanc opened a new pull request, #13065:
URL: https://github.com/apache/arrow/pull/13065
If RecordBuilder.UnmarshalJSON encountered an unknown field in the JSON document; it wouldn't consume the next JSON token representing the value.
Fix this by manually calling `dec.Token()` and allowing the next call to `dec.Token()` to return the following key.
Note that this only handles the case where the ignored value is a simple type, and not a nested array or object. I'm not sure what the correct fix for that would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13065: ARROW-16456: [Go] Fix RecordBuilder UnmarshalJSON when extra fields are present
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13065:
URL: https://github.com/apache/arrow/pull/13065#issuecomment-1117260656
https://issues.apache.org/jira/browse/ARROW-16456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13065: ARROW-16456: [Go] Fix RecordBuilder UnmarshalJSON when extra fields are present
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13065:
URL: https://github.com/apache/arrow/pull/13065#issuecomment-1117260680
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #13065: ARROW-16456: [Go] Fix RecordBuilder UnmarshalJSON when extra fields are present
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #13065: ARROW-16456: [Go] Fix RecordBuilder UnmarshalJSON when extra fields are present
URL: https://github.com/apache/arrow/pull/13065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13065: ARROW-16456: [Go] Fix RecordBuilder UnmarshalJSON when extra fields are present
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13065:
URL: https://github.com/apache/arrow/pull/13065#issuecomment-1120452867
Benchmark runs are scheduled for baseline = 8acb3c405fe684d5638416c57d0a5f5b68cd3272 and contender = 7a7e1a748eed50d7ac43ab0c158422da8c078841. 7a7e1a748eed50d7ac43ab0c158422da8c078841 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/431cce7d4c32466d9f408790510e1d0a...a1c56afd4be14d498ab3c55593b40318/)
[Failed :arrow_down:2.29% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a1dd31e72bf74b3190d968f837bfc7a3...5d2dd34089b345319e09eb03b922f9ec/)
[Finished :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e6ca85ffd6244ee69677da2a7ec545a6...530ef3e90ec2427991148f92980d153d/)
[Finished :arrow_down:0.16% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6018b13bc5b04bcd8a5a92c75aa62e62...43484e7f09144561a781aa0a65e1d67a/)
Buildkite builds:
[Finished] [`7a7e1a74` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/700)
[Failed] [`7a7e1a74` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/697)
[Finished] [`7a7e1a74` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/686)
[Finished] [`7a7e1a74` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/702)
[Finished] [`8acb3c40` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/699)
[Finished] [`8acb3c40` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/696)
[Finished] [`8acb3c40` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/685)
[Finished] [`8acb3c40` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/701)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13065: ARROW-16456: [Go] Fix RecordBuilder UnmarshalJSON when extra fields are present
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13065:
URL: https://github.com/apache/arrow/pull/13065#issuecomment-1120452891
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e6ca85ffd6244ee69677da2a7ec545a6...530ef3e90ec2427991148f92980d153d/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org