You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/11/02 20:04:10 UTC
Review Request 39868: Moved ProvisionerProcess to header for testing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39868/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jojy Varghese.
Repository: mesos
Description
-------
Moved ProvisionerProcess to header for testing.
Diffs
-----
src/slave/containerizer/mesos/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
src/slave/containerizer/mesos/provisioner/provisioner.cpp e99c1c9876b836be5d3efcef7408b5ed01d8984e
Diff: https://reviews.apache.org/r/39868/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39868: Moved ProvisionerProcess to header for
testing.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39868/#review104839
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 49)
<https://reviews.apache.org/r/39868/#comment163104>
Sort them alphebetically
- Jie Yu
On Nov. 2, 2015, 7:04 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39868/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:04 p.m.)
>
>
> Review request for mesos, Jie Yu and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved ProvisionerProcess to header for testing.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
> src/slave/containerizer/mesos/provisioner/provisioner.cpp e99c1c9876b836be5d3efcef7408b5ed01d8984e
>
> Diff: https://reviews.apache.org/r/39868/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39868: Moved ProvisionerProcess to header for
testing.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39868/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 9:03 p.m.)
Review request for mesos, Jie Yu and Jojy Varghese.
Repository: mesos
Description
-------
Moved ProvisionerProcess to header for testing.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
src/slave/containerizer/mesos/provisioner/provisioner.cpp e99c1c9876b836be5d3efcef7408b5ed01d8984e
Diff: https://reviews.apache.org/r/39868/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39868: Moved ProvisionerProcess to header for
testing.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39868/#review104803
-----------------------------------------------------------
Ship it!
LGTM.
- Gilbert Song
On Nov. 2, 2015, 11:04 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39868/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 11:04 a.m.)
>
>
> Review request for mesos, Jie Yu and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved ProvisionerProcess to header for testing.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
> src/slave/containerizer/mesos/provisioner/provisioner.cpp e99c1c9876b836be5d3efcef7408b5ed01d8984e
>
> Diff: https://reviews.apache.org/r/39868/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39868: Moved ProvisionerProcess to header for
testing.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39868/#review104838
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 37)
<https://reviews.apache.org/r/39868/#comment163103>
Kill one extra line here.
- Jie Yu
On Nov. 2, 2015, 7:04 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39868/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:04 p.m.)
>
>
> Review request for mesos, Jie Yu and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved ProvisionerProcess to header for testing.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/provisioner.hpp 912fc5abadb1219fc4baec1a751010522bc7a7d0
> src/slave/containerizer/mesos/provisioner/provisioner.cpp e99c1c9876b836be5d3efcef7408b5ed01d8984e
>
> Diff: https://reviews.apache.org/r/39868/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>