You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2023/01/09 06:40:34 UTC
[GitHub] [yunikorn-core] wusamzong opened a new pull request, #495: [YUNIKORN-1520] TestApplyConf: poor unit test coverage
wusamzong opened a new pull request, #495:
URL: https://github.com/apache/yunikorn-core/pull/495
### What is this PR for?
I add some test for ApplyConf().
The test contains three part:
1. Cover error cases for SubmitACL & AdminACL
2. Check if `isManaged` will changed to `true` while process with dynamic queue
3. Check if `isLeaf` will changed to `false` while Queue's length > 0
### What type of PR is it?
* [x] - Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1520/
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #495: [YUNIKORN-1520] TestApplyConf: poor unit test coverage
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #495: [YUNIKORN-1520] TestApplyConf: poor unit test coverage
URL: https://github.com/apache/yunikorn-core/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #495: [YUNIKORN-1520] TestApplyConf: poor unit test coverage
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #495:
URL: https://github.com/apache/yunikorn-core/pull/495#issuecomment-1375171264
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/495?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#495](https://codecov.io/gh/apache/yunikorn-core/pull/495?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b73b5a) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/ef3f0c7a10b5c5362f327ba9a84b463910a2b138?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef3f0c7) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 73.07% 73.29% +0.21%
==========================================
Files 69 69
Lines 10371 10371
==========================================
+ Hits 7579 7601 +22
+ Misses 2544 2526 -18
+ Partials 248 244 -4
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/yunikorn-core/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `75.85% <0.00%> (+2.08%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org