You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (JIRA)" <ji...@apache.org> on 2013/01/25 18:23:14 UTC

[jira] [Resolved] (SOLR-4325) DIH DateFormatEvaluator seems to have problems with DST changes -> test disabled

     [ https://issues.apache.org/jira/browse/SOLR-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Dyer resolved SOLR-4325.
------------------------------

    Resolution: Fixed
    
> DIH DateFormatEvaluator seems to have problems with DST changes -> test disabled
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-4325
>                 URL: https://issues.apache.org/jira/browse/SOLR-4325
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.0, 4.1
>            Reporter: Uwe Schindler
>            Assignee: James Dyer
>             Fix For: 4.2, 5.0
>
>         Attachments: SOLR-4325.patch
>
>
> Yesterday was DST change in Fidji (clock went one hour backwards, as summer time ended and winter time started). This caused org.apache.solr.handler.dataimport.TestBuiltInEvaluators.testDateFormatEvaluator to fail. The reason is simple: NOW-2DAYS is evaluated without taking time zone into account (its substracting 48 hours), but to be correct and go 2 DAYS back in local wall clock time, it must subtract only 47 hours. If this is not intended (we want to go 48 hours back, not 47), the test needs a fix. Otherwise the date evaluator must take the timezone into account when substracting days (e.g., use correctly localized Calendar instance and use the add() method ([http://docs.oracle.com/javase/6/docs/api/java/util/Calendar.html#add(int, int)]).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org