You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (JIRA)" <ji...@apache.org> on 2015/07/18 22:59:04 UTC
[jira] [Comment Edited] (SOLR-7730) speed-up faceting on doc values
fields
[ https://issues.apache.org/jira/browse/SOLR-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632573#comment-14632573 ]
Mikhail Khludnev edited comment on SOLR-7730 at 7/18/15 8:58 PM:
-----------------------------------------------------------------
[this|https://github.com/m-khl/lucene-solr/compare/b6c9cf136e915df7b...SOLR-7730-SCWR-DV-opt?diff=split&name=SOLR-7730-SCWR-DV-opt] allows to look in the context.
It would be great if you can check the gain it with your recent benchmark on 10 or more segments index.
was (Author: mkhludnev):
[this|https://github.com/m-khl/lucene-solr/blame/SOLR-7730-SCWR-DV-opt/lucene/core/src/java/org/apache/lucene/index/SlowCompositeReaderWrapper.java#L141] allows to look in the context.
It would be great if you can check the gain it with your recent benchmark on 10 or more segments index.
> speed-up faceting on doc values fields
> --------------------------------------
>
> Key: SOLR-7730
> URL: https://issues.apache.org/jira/browse/SOLR-7730
> Project: Solr
> Issue Type: Improvement
> Components: faceting
> Affects Versions: 5.2.1
> Reporter: Mikhail Khludnev
> Labels: patch
> Fix For: 5.3
>
> Attachments: LUCENE-7730.patch, LUCENE-7730.patch, SOLR-7730.patch
>
>
> every time we count facets on DocValues fields in Solr on many segments index we see the unnecessary hotspot:
> {code}
> ....
> at org.apache.lucene.index.MultiFields.getMergedFieldInfos(MultiFields.java:248)
> at org.apache.lucene.index.SlowCompositeReaderWrapper.getFieldInfos(SlowCompositeReaderWrapper.java:239)
> at org.apache.lucene.index.SlowCompositeReaderWrapper.getSortedSetDocValues(SlowCompositeReaderWrapper.java:176)
> at org.apache.solr.request.DocValuesFacets.getCounts(DocValuesFacets.java:72)
> at org.apache.solr.request.SimpleFacets.getTermCounts(SimpleFacets.java:460) ....
> {code}
> the reason is SlowCompositeReaderWrapper.getSortedSetDocValues() Line 136 and SlowCompositeReaderWrapper.getSortedDocValues() Line 174
> before return composite doc values, SCWR merges segment field infos, which is expensive, but after fieldinfo is merged, it checks *only* docvalue type in it. This dv type check can be done much easier in per segment basis.
> This patch gets some performance gain for those who count DV facets in Solr.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org