You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by svarnau <gi...@git.apache.org> on 2015/11/13 19:21:53 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1417] Reduce location...
GitHub user svarnau opened a pull request:
https://github.com/apache/incubator-trafodion/pull/173
[TRAFODION-1417] Reduce locations to change release version number
To change the trafodion release version major/minor number, there were about a dozen locations in four different files that needed to be modified.
This set of changes eliminates all those places except for the single place in core/sqf/sqenvcom.sh.
It does add maven warnings in DCS and REST build logs, same as in other components that already use maven with environment variable version number.
jdbc_test.py script now takes additional options to pass in correct version numbers. If you use swjdbc script, then it is taken care of. Other environments that call jdbc_test.py directly (e.g., jenkins test automation) should also be changed. But the default values match the current release, so the change is not urgent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/svarnau/incubator-trafodion versioning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit aebe120abfb91b3a84db3c1ddb3367f4f0cb14fa
Author: Steve Varnau <st...@esgyn.com>
Date: 2015-11-12T21:59:58Z
Reduce places to change release version in pom.xml files
commit 0ea3810b489de3fcafddfb06d4f09d4d23571901
Author: Steve Varnau <st...@esgyn.com>
Date: 2015-11-13T00:22:55Z
Replace project.version value with environment variable for dcs and rest
This causes warnings from maven, but is consistent with practice in
other pom files in trafodion tree to keep release version the same in
multiple components.
commit 982804b0d6273c7571170eec1a4dd61ac4d3125d
Author: Steve Varnau <st...@esgyn.com>
Date: 2015-11-13T18:06:36Z
Pass current DB version to jdbc tests
This enables taking expected response from environment or command line
instead of requiring test source code to change every release.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1417] Reduce location...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---